Re: [PATCH v2 5/6] [gdb/testsuite] sme2: Extend SME tests to include SME2

[Luis Machado <luis.machado@arm.com>]

On 8/27/23 02:23, Thiago Jung Bauermann wrote:
> 
> Luis Machado <luis.machado@arm.com> writes:
> 
>> diff --git a/gdb/testsuite/lib/aarch64.exp b/gdb/testsuite/lib/aarch64.exp
>> index cd43a4c4f77..40bba861b5f 100644
>> --- a/gdb/testsuite/lib/aarch64.exp
>> +++ b/gdb/testsuite/lib/aarch64.exp
>> @@ -151,3 +151,56 @@ proc check_fpsimd_regs { byte state vl svl} {
>>  	gdb_test "print $register_name" $fpsimd_pattern
>>      }
>>  }
>> +
>> +#
>> +# Validate the values of the SVE registers.
>> +#
>> +proc check_sve_regs { byte state vl svl } {
> 
> This is a duplicate of the same function in aarch64-scalable.exp. It
> seems to be included here by mistake.
> 

Oops. Missed removing that entry when I split aarch64.exp.

Removed now.

Thanks for the reviews!

>> +
>> +    # If streaming mode is enabled, the vector length is the streaming
>> +    # vector length.
>> +    set z_pattern ""
>> +    set z_size 0
>> +    if {$state == "ssve" || $state == "za_ssve"} {
>> +	set z_pattern [string_to_regexp [1d_array_value_pattern $byte $svl]]
>> +	set z_size $svl
>> +    } else {
>> +	set z_size $vl
>> +
>> +	if {$state == "fpsimd" || $state == "za"} {
>> +	    # If there is no SVE/SSVE state, the contents of the Z/P/FFR registers
>> +	    # are zero.
>> +	    if {$vl == 16} {
>> +		set z_pattern [string_to_regexp [1d_array_value_pattern $byte $vl]]
>> +	    } else {
>> +		set z_repeats [expr $vl - 16]
>> +		set z_pattern [string_to_regexp "{$byte <repeats 16 times>, 0 <repeats $z_repeats times>}"]
>> +	      }
>> +	} else {
>> +	    set z_pattern [string_to_regexp [1d_array_value_pattern $byte $vl]]
>> +	}
>> +    }
>> +    set p_size [expr $z_size / 8]
>> +
>> +    # If there is no SVE/SSVE state, the contents of the Z/P/FFR registers
>> +    # are zero.
>> +    set p_byte $byte
>> +    if {$state == "fpsimd" || $state == "za"} {
>> +	set p_byte 0
>> +    }
>> +    set p_pattern [string_to_regexp [1d_array_value_pattern $p_byte $p_size]]
>> +
>> +    for {set number 0} {$number < 32} {incr number} {
>> +	set register_name "\$z${number}\.b\.u"
>> +	gdb_test "print sizeof $register_name" " = $z_size"
>> +	gdb_test "print $register_name" $z_pattern
>> +    }
>> +
>> +    for {set number 0} {$number < 16} {incr number} {
>> +	set register_name "\$p${number}"
>> +	gdb_test "print sizeof $register_name" " = $p_size"
>> +	gdb_test "print $register_name" $p_pattern
>> +    }
>> +
>> +    gdb_test "print \$ffr" $p_pattern
>> +}
> 
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
>