Re: [PATCH] Verify COFF symbol stringtab offset

[Keith Seitz <keiths@redhat.com>]

On 8/22/23 08:46, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Keith> Unfortunately, I haven't any idea how else to test this patch since
> Keith> COFF is not very common anymore. GCC removed support for it five
> Keith> years ago with GCC 8.
> 
> If it is really that dead, then -- like stabs -- I'd like to remove it.
> These dead formats just make it harder to improve gdb while not
> providing value to any user.
> 
> Actually with the advent of fuzzers, this code now has negative value,
> because it wastes time coming up with patches to fix bugs in code no one
> uses.

I was tempted to suggest either removing it or at least adding a --disable-reader-coff
option to disable the code, but I could not convince myself that there
wouldn't be relatively widespread disagreement.

If you feel there's a chance, let me know if you like either of these approaches,
and I will get it on my TODO list.

> Hmm, I should probably go reply on the stabs thread.
> 
> Anyway, this is ok.

Thank you again for your quick review! Pushed  58abdf88782.

Keith