From: Tom Tromey <tom@tromey.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Verify COFF symbol stringtab offset
Date: Mon, 28 Aug 2023 10:53:36 -0600 [thread overview]
Message-ID: <878r9vt8fj.fsf@tromey.com> (raw)
In-Reply-To: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com> (Keith Seitz via Gdb-patches's message of "Fri, 25 Aug 2023 12:46:48 -0700")
>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>> If it is really that dead, then -- like stabs -- I'd like to remove
>> it. These dead formats just make it harder to improve gdb while not
>> providing value to any user. Actually with the advent of fuzzers,
>> this code now has negative value, because it wastes time coming up
>> with patches to fix bugs in code no one uses.
Keith> I was tempted to suggest either removing it or at least adding a
Keith> --disable-reader-coff option to disable the code, but I could not
Keith> convince myself that there wouldn't be relatively widespread
Keith> disagreement.
If we think the format is truly obsolete, then IMO it is better to just
delete it.
I never got back to replying about the stabs situation, but after Pedro
weighed in, I think we should move ahead with that. However, we're
close-ish to GDB 14 now, so I plan to wait until after that branches.
The main problem for other formats is even knowing if they are in use.
Searching for buildsym-legacy, I see coffread (I guess COFF had some
kind of debuginfo?), dbxread (a.out but maybe stabs-like?), mdebugread
(ECOFF), xcoffread (yet another COFF).
My guess is that maybe only xcoffread could even be remotely relevant
but I don't really know how to tell.
Tom
prev parent reply other threads:[~2023-08-28 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:23 Keith Seitz
2023-08-22 15:46 ` Tom Tromey
2023-08-25 19:46 ` Keith Seitz
2023-08-28 16:53 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r9vt8fj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).