From: Tom Tromey <tom@tromey.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Cc: Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Verify COFF symbol stringtab offset
Date: Tue, 22 Aug 2023 09:46:24 -0600 [thread overview]
Message-ID: <877cpnw04v.fsf@tromey.com> (raw)
In-Reply-To: <20230822152335.231921-1-keiths@redhat.com> (Keith Seitz via Gdb-patches's message of "Tue, 22 Aug 2023 08:23:35 -0700")
>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
Keith> This patch addresses an issue with malformed/fuzzed debug information that
Keith> was recently reported in gdb/30639. That bug specifically deals with
Keith> an ASAN issue, but the reproducer provided by the reporter causes a
Keith> another failure outside of ASAN:
Thank you.
Keith> Unfortunately, I haven't any idea how else to test this patch since
Keith> COFF is not very common anymore. GCC removed support for it five
Keith> years ago with GCC 8.
If it is really that dead, then -- like stabs -- I'd like to remove it.
These dead formats just make it harder to improve gdb while not
providing value to any user.
Actually with the advent of fuzzers, this code now has negative value,
because it wastes time coming up with patches to fix bugs in code no one
uses.
Hmm, I should probably go reply on the stabs thread.
Anyway, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-08-22 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:23 Keith Seitz
2023-08-22 15:46 ` Tom Tromey [this message]
2023-08-25 19:46 ` Keith Seitz
2023-08-28 16:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cpnw04v.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).