From: Lancelot SIX <Lancelot.Six@amd.com>
To: Simon Marchi <simark@simark.ca>,
Andrew Burgess <aburgess@redhat.com>,
Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH RFC] Require c++17 compiler
Date: Thu, 5 Oct 2023 15:55:50 +0100 [thread overview]
Message-ID: <3c031ebd-4011-48f7-9cf5-0bd87797808c@amd.com> (raw)
In-Reply-To: <ad73c9d5-f001-4592-bfb8-a518d15d6bc6@simark.ca>
>
> Wouldn't it be a simple find and replace, gdb::optional to
> std::optional? Conveniently, it's the same number of characters, so it
> doesn't even affect line-wrapping.
>
> Simon
I guess it is mostly true, there could be some cases where one can do
namespace gdb {
optional<Foo> f;
}
But I really don't think we have many of such occurrences.
So in the end, I agree that that is a viable option with a big-ish patch.
Best,
Lancelot.
next prev parent reply other threads:[~2023-10-05 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 6:54 [RFC] [gdb/build] " Tom de Vries
2023-10-05 10:33 ` [PATCH RFC] " Lancelot SIX
2023-10-05 12:26 ` Andrew Burgess
2023-10-05 14:26 ` Lancelot SIX
2023-10-05 14:32 ` Simon Marchi
2023-10-05 14:55 ` Lancelot SIX [this message]
2023-10-09 14:32 ` Andrew Burgess
2023-10-05 15:55 ` Tom Tromey
2023-10-12 17:30 ` Pedro Alves
2023-10-05 15:31 ` [RFC] [gdb/build] " Tom Tromey
2023-10-10 17:39 ` Tom Tromey
2023-10-10 19:16 ` Simon Marchi
2023-10-12 17:10 ` Pedro Alves
2023-10-12 17:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c031ebd-4011-48f7-9cf5-0bd87797808c@amd.com \
--to=lancelot.six@amd.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).