Re: [PATCH RFC] Require c++17 compiler

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> On 10/5/23 10:26, Lancelot SIX via Gdb-patches wrote:
>> If you take something like gdb::optional for example, it is used quite
>> extensively in the codebase, and I don't think it would be easy to
>> remove the it in favor of the standard C++ version any time soon.  We
>> can have gdb::optional be an alias to std::optional, but the codebase
>> will still continue to use "gdb::optional" independently of how this
>> is implemented.

Simon> Wouldn't it be a simple find and replace, gdb::optional to
Simon> std::optional?  Conveniently, it's the same number of characters, so it
Simon> doesn't even affect line-wrapping.

I wrote a patch to make gdb_optional.h check __cplusplus and use the
C++17 std::optional.  I had to comment out some of the test code to get
it to compile (warnings about set-but-unused variables), but other than
that it seems fine.  I'm running the test suite now.

Tom