From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lancelot.six@amd.com>, Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH RFC] Require c++17 compiler
Date: Thu, 12 Oct 2023 18:30:14 +0100 [thread overview]
Message-ID: <5a253bff-8e20-443c-9f7c-0bdc8d7c0841@palves.net> (raw)
In-Reply-To: <20231005103354.5loeki67slszfrcy@hpe6u-23>
On 2023-10-05 11:33, Lancelot SIX via Gdb-patches wrote:
> Hi Tom,
>
> Thanks for putting this together! As you know, I am in favor of such
> change (for GDB-15 probably, GDB-14 branching is probably too close)!
>
> I do have a really similar patch available on a local branch. One
> difference though is that my branch uses a preparatory patch to upgrade
> gdb/ax_cxx_compile_stdcxx.m4 to follow upstream changes to this file.
> This upgrade gives some improvements in the C++17 compiler detection.
> We keep this in the GDB tree because it has some local changes to set
> CXX_DIALECT. This preparatory patch should be included in this reply.
>
(As discussed at the Cauldron,) I agree it would be nice to do that, either
before or after the C++17 requirement change. Your attached patch looks fine to me.
next prev parent reply other threads:[~2023-10-12 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 6:54 [RFC] [gdb/build] " Tom de Vries
2023-10-05 10:33 ` [PATCH RFC] " Lancelot SIX
2023-10-05 12:26 ` Andrew Burgess
2023-10-05 14:26 ` Lancelot SIX
2023-10-05 14:32 ` Simon Marchi
2023-10-05 14:55 ` Lancelot SIX
2023-10-09 14:32 ` Andrew Burgess
2023-10-05 15:55 ` Tom Tromey
2023-10-12 17:30 ` Pedro Alves [this message]
2023-10-05 15:31 ` [RFC] [gdb/build] " Tom Tromey
2023-10-10 17:39 ` Tom Tromey
2023-10-10 19:16 ` Simon Marchi
2023-10-12 17:10 ` Pedro Alves
2023-10-12 17:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a253bff-8e20-443c-9f7c-0bdc8d7c0841@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).