Re: [PATCH RFC] Require c++17 compiler

[Andrew Burgess <aburgess@redhat.com>]

Lancelot SIX <Lancelot.Six@amd.com> writes:

>> 
>> Wouldn't it be a simple find and replace, gdb::optional to
>> std::optional?  Conveniently, it's the same number of characters, so it
>> doesn't even affect line-wrapping.
>> 
>> Simon
>
> I guess it is mostly true, there could be some cases where one can do
>
> namespace gdb {
>    optional<Foo> f;
> }
>
> But I really don't think we have many of such occurrences.
>
> So in the end, I agree that that is a viable option with a big-ish patch.

I agree with Simon; when we move to C++17 we'll just rip out
gdb::optional and have one big patch to move us to std::optional.  I
don't see this as a problem.

We can easily do the same with gdb::make_unique too.

Hopefully once GDB 14 releases, we can go ahead and move to C++17 so
this issue will resolve itself.

Thanks,
Andrew