From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE
Date: Wed, 21 Sep 2022 11:01:41 -0400 [thread overview]
Message-ID: <48caddaf-2fe5-0f7a-3016-1891933ffe02@simark.ca> (raw)
In-Reply-To: <20220921143750.pkzms5alxkvhtcwf@ubuntu.lan>
On 2022-09-21 10:37, Lancelot SIX via Gdb-patches wrote:
> Hi,
>
> When applying it locally, I have:
>
> Applying: gdb: remove TYPE_TARGET_TYPE
> .git/rebase-apply/patch:4243: space before tab in indent.
> current_type = current_type->target_type ();
> warning: 1 line adds whitespace errors.
Not my fault, they were already there! Fixed anyhow, thanks for
pointing it out.
> On Fri, Sep 16, 2022 at 11:08:34AM -0400, Simon Marchi via Gdb-patches wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> Remove the macro, replace all uses by calls to type::length.
> ^
> I think you meant type::target_type here.
Indeed, thanks.
> Also after applying the patch, git grep TYPE_TARGET_TYPE gives me:
>
> gdb/ada-lang.c: the result of this function in the TYPE_TARGET_TYPE of the
> gdb/c-typeprint.c: couldn't resolve TYPE_TARGET_TYPE. Not much we can do. */
> gdb/gdbtypes.c: NOTE: This will return a typedef if TYPE_TARGET_TYPE for the typedef has
> gdb/m2-typeprint.c: /* FIXME: TYPE_TARGET_TYPE used to be TYPE_DOMAIN_TYPE but that was
> gdb/m2-typeprint.c: wrong. Not sure if TYPE_TARGET_TYPE is correct though. */
> gdb/m2-typeprint.c: * type of _m2_contents is a pointer. The TYPE_TARGET_TYPE
>
> All those occurrences are in comments, but I think that it would help
> future readers to update those new spots as well.
Yeah, there are some occurences for other macros as well. I will update
these to say "type::target_type" instead. There are some occurences
(not of TYPE_TARGET_TYPE but some other macro) that is in some commented
out code that is probably quite stale. I don't know how relevant it is
to update that, but I guess it doesn't hurt.
> Otherwise, and for what it is worth considering I am not a maintainer,
> this looks reasonable to me. Thanks for taking the time to make those
> tree-wide changes!
Cool, thanks for taking a look.
Simon
next prev parent reply other threads:[~2022-09-21 15:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 15:08 [PATCH 1/4] gdb: add type::target_type / type::set_target_type Simon Marchi
2022-09-16 15:08 ` [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE Simon Marchi
2022-09-21 14:37 ` Lancelot SIX
2022-09-21 15:01 ` Simon Marchi [this message]
2022-09-21 14:57 ` Tom Tromey
2022-09-21 15:02 ` Simon Marchi
2022-09-16 15:08 ` [PATCH 3/4] gdb: add type::length / type::set_length Simon Marchi
2022-09-21 15:00 ` Tom Tromey
2022-09-21 15:01 ` Lancelot SIX
2022-09-21 16:44 ` Tom Tromey
2022-09-21 17:00 ` Simon Marchi
2022-09-21 18:48 ` Lancelot SIX
2022-09-17 9:48 ` [RESEND PATCH 4/4] gdb: remove TYPE_LENGTH Simon Marchi
2022-09-21 15:03 ` Tom Tromey
2022-09-21 15:04 ` Simon Marchi
2022-09-21 14:52 ` [PATCH 1/4] gdb: add type::target_type / type::set_target_type Tom Tromey
2022-09-21 14:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48caddaf-2fe5-0f7a-3016-1891933ffe02@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).