From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>,
Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCH 3/4] gdb: add type::length / type::set_length
Date: Wed, 21 Sep 2022 13:00:01 -0400 [thread overview]
Message-ID: <fb86071e-d457-dfee-fa92-babc79c54608@simark.ca> (raw)
In-Reply-To: <87leqc3cfb.fsf@tromey.com>
On 2022-09-21 12:44, Tom Tromey wrote:
>>>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>>> - TYPE_LENGTH (array_type) = (array_bitsize + 7) / 8;
>>> + array_type->set_length ((array_bitsize + 7) / 8);
>
> Lancelot> Do you think that while at it you could also replace the 7 and 8
> Lancelot> literals with appropriate configured values?
>
> ...
> Lancelot> / HOST_CHAR_BIT);
>
> Normally I think the '8' is a target value, not a host value.
> Like, if HOST_CHAR_BIT != 8, would this do the wrong thing?
Sorry, Lancelot, I missed your message before pushing. In any case, I
wouldn't have done this change in that patch, as it's orthogonal.
I wouldn't worry about HOST_CHAR_BIT every being anything other than 8.
Simon
next prev parent reply other threads:[~2022-09-21 17:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 15:08 [PATCH 1/4] gdb: add type::target_type / type::set_target_type Simon Marchi
2022-09-16 15:08 ` [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE Simon Marchi
2022-09-21 14:37 ` Lancelot SIX
2022-09-21 15:01 ` Simon Marchi
2022-09-21 14:57 ` Tom Tromey
2022-09-21 15:02 ` Simon Marchi
2022-09-16 15:08 ` [PATCH 3/4] gdb: add type::length / type::set_length Simon Marchi
2022-09-21 15:00 ` Tom Tromey
2022-09-21 15:01 ` Lancelot SIX
2022-09-21 16:44 ` Tom Tromey
2022-09-21 17:00 ` Simon Marchi [this message]
2022-09-21 18:48 ` Lancelot SIX
2022-09-17 9:48 ` [RESEND PATCH 4/4] gdb: remove TYPE_LENGTH Simon Marchi
2022-09-21 15:03 ` Tom Tromey
2022-09-21 15:04 ` Simon Marchi
2022-09-21 14:52 ` [PATCH 1/4] gdb: add type::target_type / type::set_target_type Tom Tromey
2022-09-21 14:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb86071e-d457-dfee-fa92-babc79c54608@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).