public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/4] gdb: add type::target_type / type::set_target_type
Date: Wed, 21 Sep 2022 08:55:20 -0600	[thread overview]
Message-ID: <87o7v84w13.fsf@tromey.com> (raw)
In-Reply-To: <20220916150836.527213-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 16 Sep 2022 11:08:33 -0400")

Simon> Add the `target_type` and `set_target_type` methods on `struct type`, in order
Simon> to remove the `TYPE_TARGET_TYPE` macro.  In this patch, the macro is changed to
Simon> use the getter, so all the call sites of the macro that are used as a setter
Simon> are changed to use the setter method directly.  The next patch will remove the
Simon> macro completely.

Looks good.  Thank you.

Tom

      parent reply	other threads:[~2022-09-21 14:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 15:08 Simon Marchi
2022-09-16 15:08 ` [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE Simon Marchi
2022-09-21 14:37   ` Lancelot SIX
2022-09-21 15:01     ` Simon Marchi
2022-09-21 14:57   ` Tom Tromey
2022-09-21 15:02     ` Simon Marchi
2022-09-16 15:08 ` [PATCH 3/4] gdb: add type::length / type::set_length Simon Marchi
2022-09-21 15:00   ` Tom Tromey
2022-09-21 15:01   ` Lancelot SIX
2022-09-21 16:44     ` Tom Tromey
2022-09-21 17:00       ` Simon Marchi
2022-09-21 18:48       ` Lancelot SIX
2022-09-17  9:48 ` [RESEND PATCH 4/4] gdb: remove TYPE_LENGTH Simon Marchi
2022-09-21 15:03   ` Tom Tromey
2022-09-21 15:04     ` Simon Marchi
2022-09-21 14:52 ` [PATCH 1/4] gdb: add type::target_type / type::set_target_type Tom Tromey
2022-09-21 14:55 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7v84w13.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).