Re: [PATCH 2/4] gdb: remove TYPE_TARGET_TYPE

[Lancelot SIX <lsix@lancelotsix.com>]

Hi,

When applying it locally, I have:

    Applying: gdb: remove TYPE_TARGET_TYPE
    .git/rebase-apply/patch:4243: space before tab in indent.
                                current_type = current_type->target_type ();
    warning: 1 line adds whitespace errors.

On Fri, Sep 16, 2022 at 11:08:34AM -0400, Simon Marchi via Gdb-patches wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Remove the macro, replace all uses by calls to type::length.
                                                       ^
I think you meant type::target_type here.

Also after applying the patch, git grep TYPE_TARGET_TYPE gives me:

    gdb/ada-lang.c:   the result of this function in the TYPE_TARGET_TYPE of the
    gdb/c-typeprint.c:       couldn't resolve TYPE_TARGET_TYPE.  Not much we can do.  */
    gdb/gdbtypes.c:   NOTE: This will return a typedef if TYPE_TARGET_TYPE for the typedef has
    gdb/m2-typeprint.c:      /* FIXME: TYPE_TARGET_TYPE used to be TYPE_DOMAIN_TYPE but that was
    gdb/m2-typeprint.c:      wrong.  Not sure if TYPE_TARGET_TYPE is correct though.  */
    gdb/m2-typeprint.c:       *  type of _m2_contents is a pointer.  The TYPE_TARGET_TYPE

All those occurrences are in comments, but I think that it would help
future readers to update those new spots as well.

Otherwise, and for what it is worth considering I am not a maintainer,
this looks reasonable to me.  Thanks for taking the time to make those
tree-wide changes!

Lancelot.