From: Keith Seitz <keiths@redhat.com>
To: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c
Date: Tue, 20 Sep 2022 09:54:45 -0700 [thread overview]
Message-ID: <58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com> (raw)
In-Reply-To: <20220920094515.58156-1-jiangshuai_li@linux.alibaba.com>
On 9/20/22 02:45, Jiangshuai Li via Gdb-patches wrote:
> Add cskyv2-linux.xml for re-generating cskyv2-linux.c if needed.
Thank you for posting this! I have a patch waiting for it. :-)
> gdb/features/Makefile | 1 +
> gdb/features/cskyv2-linux.xml | 102 ++++++++++++++++++++++++++++++++++
> 2 files changed, 103 insertions(+)
> create mode 100644 gdb/features/cskyv2-linux.xml
I think that cskyv2-linux.c needs to be regenerated. If I apply
your patch locally, it does not give me the same file back.
[I believe this is because cskyv2-linux.c was not properly generated
when it was committed.]
For example, create_feature_cskyv2_linux should take two arguments, but
the committed file only takes one (partial diff against locally regenerated
cskyv2-linux.c):
-static void
-create_feature_cskyv2_linux (struct target_desc *result)
+static int
+create_feature_cskyv2_linux (struct target_desc *result, long regnum)
Otherwise, LGTM, and I would encourage a maintainer to approve this.
Keith
next prev parent reply other threads:[~2022-09-20 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:45 Jiangshuai Li
2022-09-20 16:54 ` Keith Seitz [this message]
2022-09-20 20:25 ` Tom Tromey
2022-09-22 2:28 jiangshuai_li
2022-09-22 2:28 ` jiangshuai_li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jiangshuai_li@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).