From: "jiangshuai_li" <jiangshuai_li@linux.alibaba.com>
To: "Keith Seitz via Gdb-patches" <gdb-patches@sourceware.org>,
"Tom Tromey" <tom@tromey.com>
Subject: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c
Date: Thu, 22 Sep 2022 10:28:50 +0800 [thread overview]
Message-ID: <e1139001-0ced-4693-90cf-8525404122fa.jiangshuai_li@linux.alibaba.com> (raw)
>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>Keith> I think that cskyv2-linux.c needs to be regenerated. If I apply
>Keith> your patch locally, it does not give me the same file back.
>Keith> [I believe this is because cskyv2-linux.c was not properly generated
>Keith> when it was committed.]
>
>Thanks for checking this.
>
>Keith> Otherwise, LGTM, and I would encourage a maintainer to approve this.
>
>I think it's good with the problem fixed.
>It's important for the primary sources to be checked in.
Thank you Keith and Tom, i have send 【PATCH v2 ...】 for this case at
https://sourceware.org/pipermail/gdb-patches/2022-September/192017.html.
Jiangshuai
WARNING: multiple messages have this Message-ID
From: "jiangshuai_li" <jiangshuai_li@linux.alibaba.com>
To: "Keith Seitz via Gdb-patches" <gdb-patches@sourceware.org>,
"Tom Tromey" <tom@tromey.com>
Cc: "Keith Seitz" <keiths@redhat.com>
Subject: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c
Date: Thu, 22 Sep 2022 10:28:50 +0800 [thread overview]
Message-ID: <e1139001-0ced-4693-90cf-8525404122fa.jiangshuai_li@linux.alibaba.com> (raw)
Message-ID: <20220922022850.ljumUwzxgrA7J1fTB-ifxfv_UAmqlgJtwxMEL7s76xk@z> (raw)
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>Keith> I think that cskyv2-linux.c needs to be regenerated. If I apply
>Keith> your patch locally, it does not give me the same file back.
>Keith> [I believe this is because cskyv2-linux.c was not properly generated
>Keith> when it was committed.]
>
>Thanks for checking this.
>
>Keith> Otherwise, LGTM, and I would encourage a maintainer to approve this.
>
>I think it's good with the problem fixed.
>It's important for the primary sources to be checked in.
Thank you Keith and Tom, i have send 【PATCH v2 ...】 for this case at
https://sourceware.org/pipermail/gdb-patches/2022-September/192017.html.
Jiangshuai
next reply other threads:[~2022-09-22 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 2:28 jiangshuai_li [this message]
2022-09-22 2:28 ` jiangshuai_li
-- strict thread matches above, loose matches on Subject: below --
2022-09-20 9:45 Jiangshuai Li
2022-09-20 16:54 ` Keith Seitz
2022-09-20 20:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1139001-0ced-4693-90cf-8525404122fa.jiangshuai_li@linux.alibaba.com \
--to=jiangshuai_li@linux.alibaba.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).