From: Tom Tromey <tom@tromey.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Cc: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>,
Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c
Date: Tue, 20 Sep 2022 14:25:52 -0600 [thread overview]
Message-ID: <875yhh6be7.fsf@tromey.com> (raw)
In-Reply-To: <58d119d3-670b-bb3e-13ff-9f2adbc14fc6@redhat.com> (Keith Seitz via Gdb-patches's message of "Tue, 20 Sep 2022 09:54:45 -0700")
>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
Keith> I think that cskyv2-linux.c needs to be regenerated. If I apply
Keith> your patch locally, it does not give me the same file back.
Keith> [I believe this is because cskyv2-linux.c was not properly generated
Keith> when it was committed.]
Thanks for checking this.
Keith> Otherwise, LGTM, and I would encourage a maintainer to approve this.
I think it's good with the problem fixed.
It's important for the primary sources to be checked in.
Tom
next prev parent reply other threads:[~2022-09-20 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:45 Jiangshuai Li
2022-09-20 16:54 ` Keith Seitz
2022-09-20 20:25 ` Tom Tromey [this message]
2022-09-22 2:28 jiangshuai_li
2022-09-22 2:28 ` jiangshuai_li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yhh6be7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jiangshuai_li@linux.alibaba.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).