From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str()
Date: Mon, 17 Apr 2023 14:09:09 -0400 [thread overview]
Message-ID: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> (raw)
In-Reply-To: <cover.1680608960.git.aburgess@redhat.com>
On 4/4/23 08:45, Andrew Burgess via Gdb-patches wrote:
> While working on another patch I spotted that
> $_gdb_setting_str("args") wasn't working correctly. Turns out args,
> cwd, and inferior-tty all have the same problems. This series
> resolves these issues.
That rang a bell, it's because I have fixed some of these downstream in
ROCgdb, and haven't sent it upstream yet. The downstream commit is
here:
https://github.com/ROCm-Developer-Tools/ROCgdb/commit/54d0a79614071fd62df5e2dfe793ff26cc7e31e6
I'll take a look at your patches, I presume that they will do mostly the
same thing. And if my patch does more (according to the commit message,
it fixes "remote exec-file" and "tdesc filename"), I can send what
remains after.
Simon
next prev parent reply other threads:[~2023-04-17 18:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 12:45 Andrew Burgess
2023-04-04 12:45 ` [PATCH 1/5] gdb: cleanup command creation in infcmd.c Andrew Burgess
2023-04-17 16:27 ` Tom Tromey
2023-04-04 12:45 ` [PATCH 2/5] gdb: make set/show args work with $_gdb_setting_str Andrew Burgess
2023-04-17 16:37 ` Tom Tromey
2023-04-17 18:04 ` Simon Marchi
2023-04-04 12:45 ` [PATCH 3/5] gdb: make set/show cwd " Andrew Burgess
2023-04-04 12:45 ` [PATCH 4/5] gdb: make set/show inferior-tty " Andrew Burgess
2023-04-04 12:45 ` [PATCH 5/5] gdb: make deprecated_show_value_hack static Andrew Burgess
2023-04-17 16:41 ` Tom Tromey
2023-04-28 14:57 ` Andrew Burgess
2023-07-10 17:25 ` Tom Tromey
2023-04-17 16:42 ` [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Tom Tromey
2023-04-17 18:09 ` Simon Marchi [this message]
2023-04-17 18:21 ` Simon Marchi
2023-04-28 21:53 ` Andrew Burgess
2023-04-28 16:43 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).