From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 5/5] gdb: make deprecated_show_value_hack static
Date: Mon, 17 Apr 2023 10:41:56 -0600 [thread overview]
Message-ID: <87pm8231gr.fsf@tromey.com> (raw)
In-Reply-To: <6fddb814d85dcacfcd3de87404b722d52edcc89e.1680608960.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 4 Apr 2023 13:45:31 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> The deprecated_show_value_hack function is now only used inside
Andrew> cli-setshow.c, so lets make the function static to discourage its use
Andrew> anywhere else.
Andrew> There should be no user visible changes after this commit
FWIW I wouldn't mind if we removed nearly all "show" functions and just
made some variant of deprecated_show_value_hack the standard way to
print things. Instead of munging the help text (which is
i18n-unfriendly) it could just print the option name:
(gdb) show mumble var
Current setting of "mumble variable": 23
For "auto" variables, I guess we'd eventually need to implement that
"second getter" idea and then we could remove even more of these
functions, maybe all of them.
Tom
next prev parent reply other threads:[~2023-04-17 16:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 12:45 [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Andrew Burgess
2023-04-04 12:45 ` [PATCH 1/5] gdb: cleanup command creation in infcmd.c Andrew Burgess
2023-04-17 16:27 ` Tom Tromey
2023-04-04 12:45 ` [PATCH 2/5] gdb: make set/show args work with $_gdb_setting_str Andrew Burgess
2023-04-17 16:37 ` Tom Tromey
2023-04-17 18:04 ` Simon Marchi
2023-04-04 12:45 ` [PATCH 3/5] gdb: make set/show cwd " Andrew Burgess
2023-04-04 12:45 ` [PATCH 4/5] gdb: make set/show inferior-tty " Andrew Burgess
2023-04-04 12:45 ` [PATCH 5/5] gdb: make deprecated_show_value_hack static Andrew Burgess
2023-04-17 16:41 ` Tom Tromey [this message]
2023-04-28 14:57 ` Andrew Burgess
2023-07-10 17:25 ` Tom Tromey
2023-04-17 16:42 ` [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Tom Tromey
2023-04-17 18:09 ` Simon Marchi
2023-04-17 18:21 ` Simon Marchi
2023-04-28 21:53 ` Andrew Burgess
2023-04-28 16:43 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm8231gr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).