Re: [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str()

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simark@simark.ca> writes:

> On 4/4/23 08:45, Andrew Burgess via Gdb-patches wrote:
>> While working on another patch I spotted that
>> $_gdb_setting_str("args") wasn't working correctly.  Turns out args,
>> cwd, and inferior-tty all have the same problems.  This series
>> resolves these issues.
>
> That rang a bell, it's because I have fixed some of these downstream in
> ROCgdb, and haven't sent it upstream yet.  The downstream commit is
> here:
>
> https://github.com/ROCm-Developer-Tools/ROCgdb/commit/54d0a79614071fd62df5e2dfe793ff26cc7e31e6

In case I miss this patch when you upstream it, the removal of
show_remote_exec_file should be dropped.  The generic code doesn't
handle internationalisation, and though show_remote_exec_file itself
also doesn't do internationalisation, the correct (IMHO) thing would be
to fix show_remote_exec_file, not remove it.

>
> I'll take a look at your patches, I presume that they will do mostly the
> same thing.  And if my patch does more (according to the commit message,
> it fixes "remote exec-file" and "tdesc filename"), I can send what
> remains after.

I'll take a look at the testing in your patch and see if I can extend
the tests in my patch a little.

Thanks,
Andrew