From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 2/5] gdb: make set/show args work with $_gdb_setting_str
Date: Mon, 17 Apr 2023 14:04:21 -0400 [thread overview]
Message-ID: <ab27982e-5da1-3389-993b-06a685b9b603@simark.ca> (raw)
In-Reply-To: <87ttxe31of.fsf@tromey.com>
On 4/17/23 12:37, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Luckily, the fix is pretty easy, set/show variables have an
> Andrew> alternative API which requires we provide some getter and setter
> Andrew> functions. With this done the scratch variable can be removed and the
> Andrew> value returned will now always reflect the current inferior.
>
> Wow, I didn't realize this had been implemented.
>
> I think all options requiring the "two phase" approach should be
> rewritten to this form, and the old form just removed entirely.
>
> This is related to https://sourceware.org/bugzilla/show_bug.cgi?id=12188
> but not exactly -- I guess we'd have to add a second getter API to
> convert "auto" parameters to their "current" value.
We implemented this downstream in ROCgdb, I'm currently working on
upstreaming it. I'm going through all settings, trying to see which
ones could use it.
https://review.lttng.org/c/binutils-gdb/+/9764
Simon
next prev parent reply other threads:[~2023-04-17 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 12:45 [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Andrew Burgess
2023-04-04 12:45 ` [PATCH 1/5] gdb: cleanup command creation in infcmd.c Andrew Burgess
2023-04-17 16:27 ` Tom Tromey
2023-04-04 12:45 ` [PATCH 2/5] gdb: make set/show args work with $_gdb_setting_str Andrew Burgess
2023-04-17 16:37 ` Tom Tromey
2023-04-17 18:04 ` Simon Marchi [this message]
2023-04-04 12:45 ` [PATCH 3/5] gdb: make set/show cwd " Andrew Burgess
2023-04-04 12:45 ` [PATCH 4/5] gdb: make set/show inferior-tty " Andrew Burgess
2023-04-04 12:45 ` [PATCH 5/5] gdb: make deprecated_show_value_hack static Andrew Burgess
2023-04-17 16:41 ` Tom Tromey
2023-04-28 14:57 ` Andrew Burgess
2023-07-10 17:25 ` Tom Tromey
2023-04-17 16:42 ` [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Tom Tromey
2023-04-17 18:09 ` Simon Marchi
2023-04-17 18:21 ` Simon Marchi
2023-04-28 21:53 ` Andrew Burgess
2023-04-28 16:43 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab27982e-5da1-3389-993b-06a685b9b603@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).