Re: [PATCH v2 1/5] [gdb/symtab] Factor out compunit_epilogue_unwind_valid

[Tom de Vries <tdevries@suse.de>]

On 2/14/23 23:36, Tom de Vries via Gdb-patches wrote:
> On 2/14/23 16:56, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries via Gdb-patches 
>>>>>>> <gdb-patches@sourceware.org> writes:
>>
>> Tom> Factor out compunit_epilogue_unwind_valid from both
>> Tom> amd64_stack_frame_destroyed_p and i386_stack_frame_destroyed_p.  
>> NFC.
>>
>> What does NFC means?
>>
> 
> No Functional Changes.
> 
> I guess I picked this up when working on clang/llvm.
> 
> Mentioned here: https://llvm.org/docs/Lexicon.html#n .
> 

And grepping through the commit log, I see I used it before.

Anyway, replaced by "No functional changes".

>> Tom> Also add a comment in the new function about the assumption that 
>> in absence of
>> Tom> producer information, epilogue unwind info is invalid.
>>
>> Thanks.
>> Approved-By: Tom Tromey <tom@tromey.com>
>>

Thanks, I've added the tag to this commit and will commit the series 
after retesting.

Thanks,
- Tom