Re: [PATCH v4 3/4] gdb/cli: Improve UX when using list with no args

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Bruno Larsen <blarsen@redhat.com>
> Date: Thu, 13 Jul 2023 12:24:10 +0200
> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
> 
> When using "list" with no arguments, GDB will first print the lines
> around where the inferior is stopped, then print the next N lines until
> reaching the end of file, at which point it wanrs the user "Line X out
> of range, file Y only has X-1 lines.".  This is usually desireable, but
> if the user can no longer see the original line, they may have forgotten
> the current line or that a list command was used at all, making GDB's
> error message look cryptic. It was reported in bugzilla as PR cli/30497.
> 
> This commit improves the user experince by changing the behavior of
> "list" slightly when a user passes no arguments.  It now prints that the
> end of the file has been reached and recommends that the user use the
> command "list ." instead.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30497
> ---
>  gdb/NEWS                        |  5 +++++
>  gdb/cli/cli-cmds.c              | 17 +++++++++++++----
>  gdb/doc/gdb.texinfo             |  4 +++-
>  gdb/source.c                    | 16 ++++++++++++++++
>  gdb/source.h                    |  7 +++++++
>  gdb/testsuite/gdb.base/list.exp |  8 ++++----
>  6 files changed, 48 insertions(+), 9 deletions(-)

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>