Re: [PATCH] gdb/cli: fixes to newly added "list ." command

[Bruno Larsen <blarsen@redhat.com>]

On 18/07/2023 15:43, Pedro Alves wrote:
> On 2023-07-18 12:21, Bruno Larsen via Gdb-patches wrote:
>> After the series that added this command was pushed, Pedro mentioned
>> that the news description could easily be misinterpreted, as well as
> Per the discussion, it's more than misinterpreted, it's factually incorrect.  :-)
>
>> some code and test improvements that should be made.
>>   
>>         return;
>> @@ -2805,7 +2805,7 @@ and send its output to SHELL_COMMAND."));
>>       = add_com ("list", class_files, list_command, _("\
>>   List specified function or line.\n\
>>   With no argument, lists ten more lines after or around previous listing.\n\
>> -\"list .\" lists ten lines arond where the inferior is stopped.\n\
>> +\"list .\" lists ten lines around where the inferior is stopped.\n\
> "where the inferior is stopped" should be fixed here too, as it's not what GDB does.

I'm having a hard time thinking of a concise description for it. Best I 
could come up was

+\"list .\" lists ten lines around current location in the selected frame.\n\

but that feels very jargon-y...

-- 
Cheers,
Bruno

>
>>   \"list +\" lists the ten lines following a previous ten-line listing.\n\
>>   \"list -\" lists the ten lines before a previous ten-line listing.\n\
>>   One argument specifies a line, and ten lines are listed around that line.\n\
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index cd86da50f46..c9377846bdc 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -9155,9 +9155,9 @@ Same as using with no arguments.
>>   Print lines just before the lines last printed.
>>   
>>   @item list .
>> -Print the lines surrounding the location that is where the inferior
>> -is stopped.  If the inferior is not running, print around the main
>> -function instead.
>> +Print the lines surrounding the last solitary line printed as part
>> +of displaying a fram.  If the inferior is not running, print around
> "fram" -> "frame".
>
>> +the main function instead.
>>   @end table
>