public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, blarsen@redhat.com, aburgess@redhat.com
Subject: Re: [PATCH v4] gdb/cli: fixes to newly added "list ." command
Date: Tue, 19 Sep 2023 14:27:49 +0300	[thread overview]
Message-ID: <83y1h2csi2.fsf@gnu.org> (raw)
In-Reply-To: <20230919090627.2580364-2-blarsen@redhat.com> (message from Guinevere Larsen on Tue, 19 Sep 2023 11:06:28 +0200)

> From: Guinevere Larsen <blarsen@redhat.com>
> Cc: eliz@gnu.org,
> 	Guinevere Larsen <blarsen@redhat.com>,
> 	Andrew Burgess <aburgess@redhat.com>
> Date: Tue, 19 Sep 2023 11:06:28 +0200
> 
> After the series that added this command was pushed, Pedro mentioned
> that the news description could easily be misinterpreted, as well as
> some code and test improvements that should be made.
> 
> While fixing the test, I realized that code repetition wasn't
> happening as it should, so I took care of that too.

Thanks.
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 98ff00d5efc..2837c62b163 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -90,8 +90,9 @@
>    expression parser.
>  
>  * The 'list' command now accepts '.' as an argument, which tells GDB to
> -  print the location where the inferior is stopped.  If the inferior hasn't
> -  started yet, the command will print around the main function.
> +  print the location around the point of execution within the current frame.
> +  If the inferior hasn't started yet, the command wil print around the
> +  beginning of the 'main' function.               ^^^

Typo.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -9212,9 +9212,9 @@ Same as using with no arguments.
>  Print lines just before the lines last printed.
>  
>  @item list .
> -Print the lines surrounding the location that is where the inferior
> -is stopped.  If the inferior is not running, print around the main
> -function instead.
> +Print the lines surrounding the point of execution within the
> +currently selected frame.  If the inferior is not running print lines
> +around the start of the main function instead.           ^

A comma is missing there.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2023-09-19 11:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 10:24 [PATCH v4 0/4] Small changes to "list" command Bruno Larsen
2023-07-13 10:24 ` [PATCH v4 1/4] gdb/cli: Factor out code to list lines around a given line Bruno Larsen
2023-07-13 16:53   ` Tom Tromey
2023-07-13 10:24 ` [PATCH v4 2/4] gdb/cli: add '.' as an argument for 'list' command Bruno Larsen
2023-07-13 11:05   ` Eli Zaretskii
2023-07-13 16:53   ` Tom Tromey
2023-07-14 17:50   ` Pedro Alves
2023-07-17  8:21     ` Bruno Larsen
2023-07-17  8:44       ` Andrew Burgess
2023-07-17 14:14       ` Pedro Alves
2023-07-18 11:21     ` [PATCH] gdb/cli: fixes to newly added "list ." command Bruno Larsen
2023-07-18 12:54       ` Eli Zaretskii
2023-07-18 13:40         ` Bruno Larsen
2023-07-18 16:17           ` Eli Zaretskii
2023-07-18 13:43       ` Pedro Alves
2023-07-18 14:55         ` Bruno Larsen
2023-07-21 10:26       ` [PATCH v2] " Bruno Larsen
2023-07-21 11:05         ` Eli Zaretskii
2023-08-04  8:37         ` [PING][PATCH " Bruno Larsen
2023-08-23 10:03           ` [PINGv2][PATCH " Guinevere Larsen
2023-08-23 15:00         ` [PATCH " Andrew Burgess
2023-08-28 15:50         ` [PATCH v3] " Guinevere Larsen
2023-09-14 13:00           ` [PING][PATCH " Guinevere Larsen
2023-09-18 13:16           ` [PATCH " Andrew Burgess
2023-09-19  9:06           ` [PATCH v4] " Guinevere Larsen
2023-09-19 11:27             ` Eli Zaretskii [this message]
2023-09-19 12:07               ` Guinevere Larsen
2023-07-13 10:24 ` [PATCH v4 3/4] gdb/cli: Improve UX when using list with no args Bruno Larsen
2023-07-13 11:06   ` Eli Zaretskii
2023-07-13 17:41   ` Keith Seitz
2023-07-13 10:24 ` [PATCH v4 4/4] gdb/doc: document '+' argument for 'list' command Bruno Larsen
2023-07-13 17:35   ` Keith Seitz
2023-07-13 21:30     ` Matt Rice
2023-07-14  8:53       ` Bruno Larsen
2023-07-14 16:30         ` Tom Tromey
2023-07-14 21:30           ` Matt Rice
2023-07-13 17:31 ` [PATCH v4 0/4] Small changes to "list" command Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1h2csi2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).