From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH v4 1/4] gdb/cli: Factor out code to list lines around a given line
Date: Thu, 13 Jul 2023 10:53:30 -0600 [thread overview]
Message-ID: <87zg3zoir9.fsf@tromey.com> (raw)
In-Reply-To: <20230713102411.2279542-2-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Thu, 13 Jul 2023 12:24:08 +0200")
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
Bruno> A future patch will add more situations that calculates "lines around a
Bruno> certain point" to be printed using print_source_lines, and the logic
Bruno> could be re-used. As a preparation for those commits, this one factors
Bruno> out that part of the logic of the list command into its own function.
Bruno> No functional changes are expected
Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-07-13 16:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 10:24 [PATCH v4 0/4] Small changes to "list" command Bruno Larsen
2023-07-13 10:24 ` [PATCH v4 1/4] gdb/cli: Factor out code to list lines around a given line Bruno Larsen
2023-07-13 16:53 ` Tom Tromey [this message]
2023-07-13 10:24 ` [PATCH v4 2/4] gdb/cli: add '.' as an argument for 'list' command Bruno Larsen
2023-07-13 11:05 ` Eli Zaretskii
2023-07-13 16:53 ` Tom Tromey
2023-07-14 17:50 ` Pedro Alves
2023-07-17 8:21 ` Bruno Larsen
2023-07-17 8:44 ` Andrew Burgess
2023-07-17 14:14 ` Pedro Alves
2023-07-18 11:21 ` [PATCH] gdb/cli: fixes to newly added "list ." command Bruno Larsen
2023-07-18 12:54 ` Eli Zaretskii
2023-07-18 13:40 ` Bruno Larsen
2023-07-18 16:17 ` Eli Zaretskii
2023-07-18 13:43 ` Pedro Alves
2023-07-18 14:55 ` Bruno Larsen
2023-07-21 10:26 ` [PATCH v2] " Bruno Larsen
2023-07-21 11:05 ` Eli Zaretskii
2023-08-04 8:37 ` [PING][PATCH " Bruno Larsen
2023-08-23 10:03 ` [PINGv2][PATCH " Guinevere Larsen
2023-08-23 15:00 ` [PATCH " Andrew Burgess
2023-08-28 15:50 ` [PATCH v3] " Guinevere Larsen
2023-09-14 13:00 ` [PING][PATCH " Guinevere Larsen
2023-09-18 13:16 ` [PATCH " Andrew Burgess
2023-09-19 9:06 ` [PATCH v4] " Guinevere Larsen
2023-09-19 11:27 ` Eli Zaretskii
2023-09-19 12:07 ` Guinevere Larsen
2023-07-13 10:24 ` [PATCH v4 3/4] gdb/cli: Improve UX when using list with no args Bruno Larsen
2023-07-13 11:06 ` Eli Zaretskii
2023-07-13 17:41 ` Keith Seitz
2023-07-13 10:24 ` [PATCH v4 4/4] gdb/doc: document '+' argument for 'list' command Bruno Larsen
2023-07-13 17:35 ` Keith Seitz
2023-07-13 21:30 ` Matt Rice
2023-07-14 8:53 ` Bruno Larsen
2023-07-14 16:30 ` Tom Tromey
2023-07-14 21:30 ` Matt Rice
2023-07-13 17:31 ` [PATCH v4 0/4] Small changes to "list" command Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg3zoir9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).