From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: gdb-patches@sourceware.org, apinski@marvell.com
Subject: Re: [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries
Date: Tue, 14 Mar 2023 21:38:46 +0200 [thread overview]
Message-ID: <83bkkvrum1.fsf@gnu.org> (raw)
In-Reply-To: <d06a18e4-2c22-6c81-9520-e525f6281d30@gmail.com> (message from Philippe Blain on Tue, 14 Mar 2023 13:12:19 -0400)
> Cc: gdb-patches@sourceware.org, apinski@marvell.com
> From: Philippe Blain <levraiphilippeblain@gmail.com>
> Date: Tue, 14 Mar 2023 13:12:19 -0400
>
> >>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> >>>
> >>
> >> Thanks for the reviwew. I do not have push access, would you be so
> >> kind as to push both patches ?
> >
> > My preference is to install only the first of these, for the reasons I
> > explained, but I'm waiting to hear opinions of others, if they differ.
>
> OK, thanks. let's wait a bit to see if someone else wants to chime in.
>
> I guess I was confused by the fact that 'Approved-by' is used here in a different way
> than in the Git project, where it is an explicit approval (and Approved-by is not used).
I didn't give Approved-by, I gave Reviewed-By.
next prev parent reply other threads:[~2023-03-14 19:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:46 [PATCH 0/2] doc: MPFR is now a necessary requirement Philippe Blain
2023-03-10 17:46 ` [PATCH 1/2] gdb/doc: " Philippe Blain
2023-03-10 19:15 ` Eli Zaretskii
2023-03-27 21:13 ` Simon Marchi
2023-03-29 17:21 ` Philippe Blain
2023-03-10 17:46 ` [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries Philippe Blain
2023-03-10 19:17 ` Eli Zaretskii
2023-03-13 16:45 ` Philippe Blain
2023-03-14 12:08 ` Eli Zaretskii
2023-03-14 17:12 ` Philippe Blain
2023-03-14 17:38 ` Philippe Blain
2023-03-14 19:41 ` Eli Zaretskii
2023-03-14 19:48 ` Philippe Blain
2023-03-14 19:38 ` Eli Zaretskii [this message]
2023-03-27 21:18 ` Simon Marchi
2023-03-25 22:04 ` [PATCH 0/2] doc: MPFR is now a necessary requirement Philippe Blain
[not found] ` <20230306-doc-require-mpfr-fix-v2-0-7de0f692b004@gmail.com>
[not found] ` <837cuqsbfb.fsf@gnu.org>
2023-04-07 13:19 ` [PATCH v2 " Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkkvrum1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=apinski@marvell.com \
--cc=gdb-patches@sourceware.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).