Re: [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries

[Philippe Blain <levraiphilippeblain@gmail.com>]

Hi Eli,

Le 2023-03-14 à 15:41, Eli Zaretskii a écrit :
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>> Cc: gdb-patches@sourceware.org, apinski@marvell.com
>> Date: Tue, 14 Mar 2023 13:38:08 -0400
>>
>> Le 2023-03-14 à 13:12, Philippe Blain a écrit :
>>> Hi Eli,
>>>
>> [...]
>>>
>>> I guess I was confused by the fact that 'Approved-by' is used here in a different way
>>> than in the Git project, where it is an explicit approval 
>>
>> I meant 'Reviewed-by' here, sorry.
> 
> Do they really use Reviewed-by as an approval?  _That_ would be
> confusing, since the word "review" means just that, it doesn't mean
> any approval.
> 

Yes, in the Git project, Reviewd-by is approval, see for example 
item 3. at https://git-scm.com/docs/SubmittingPatches#sign-off 
(under "If you like, you can put extra tags at the end"):


	Reviewed-by:, unlike the other tags, can only be offered by the 
	reviewers themselves when they are completely satisfied with the 
	patch after a detailed analysis.

This is in line with what it means for Linux also, as far as I understand [1].

Thanks,

Philippe.

[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes