public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: apinski@marvell.com, simon.marchi@efficios.com,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/2] doc: MPFR is now a necessary requirement
Date: Fri, 7 Apr 2023 09:19:29 -0400	[thread overview]
Message-ID: <9ae0d677-7d21-78f0-b1c5-dba22e52d490@gmail.com> (raw)
In-Reply-To: <837cuqsbfb.fsf@gnu.org>

Hi Eli,

Le 2023-04-05 à 09:31, Eli Zaretskii a écrit :
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>> Date: Mon, 03 Apr 2023 12:47:34 -0400
>>
>> This short series moves the "MPFR" requirement in the doc under the
>> "Tools/Packages Necessary for Building GDB" heading and uniformizes the wording
>> between the GMP and MPFR entries.
>>
>> I tested the HTML doc build.
>> 
>> ---
>> Changes in v2:
>> - removed "now" from the first sentence in both the GMP and MPFR entries,
>>   as suggested by Simon
>> - Link to v1: https://inbox.sourceware.org/20230306-doc-require-mpfr-fix-v1-0-8f207504dd3e@gmail.com
> 
> Thanks for working on this.
> 
> I've eventually concluded that a much deeper surgery is needed in
> these two sections:
> 
>   . the text was repetitive, basically repeating the same boilerplate
>     stuff for each library/package
>   . the arrangement was not very logical (probably alphabetical), so
>     Python was near the end and Expat was the first one
>   . some of the data was outdated (e.g., the minimum supported Python
>     version) and some URLs used non-Texinfo markup
> 
> etc.
> 
> So I've rearranged and rewritten the text, including all the fixes
> that your patches provided.  Please take a look (commit 3401f94), and
> if I left something incorrect or unhandled, please tell.

Thanks, I took a look at your commit and it is indeed a nice cleanup of the whole
section. I've just realized that I forgot to CC the list in my v2.

I've found a few things that seem to have slipped through the cracks in your 
commit, so I'll send a fixup series later today.

Thanks for acknowledging me in the commit message. Just a side note, some projects 
use special trailers for this, like 'Suggested-by', 'Original-patch-by:', etc.

Cheers,

Philippe.

      parent reply	other threads:[~2023-04-07 13:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 17:46 [PATCH " Philippe Blain
2023-03-10 17:46 ` [PATCH 1/2] gdb/doc: " Philippe Blain
2023-03-10 19:15   ` Eli Zaretskii
2023-03-27 21:13   ` Simon Marchi
2023-03-29 17:21     ` Philippe Blain
2023-03-10 17:46 ` [PATCH 2/2] gdb/doc: uniformize wording for GMP and MPFR entries Philippe Blain
2023-03-10 19:17   ` Eli Zaretskii
2023-03-13 16:45     ` Philippe Blain
2023-03-14 12:08       ` Eli Zaretskii
2023-03-14 17:12         ` Philippe Blain
2023-03-14 17:38           ` Philippe Blain
2023-03-14 19:41             ` Eli Zaretskii
2023-03-14 19:48               ` Philippe Blain
2023-03-14 19:38           ` Eli Zaretskii
2023-03-27 21:18         ` Simon Marchi
2023-03-25 22:04 ` [PATCH 0/2] doc: MPFR is now a necessary requirement Philippe Blain
     [not found] ` <20230306-doc-require-mpfr-fix-v2-0-7de0f692b004@gmail.com>
     [not found]   ` <837cuqsbfb.fsf@gnu.org>
2023-04-07 13:19     ` Philippe Blain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ae0d677-7d21-78f0-b1c5-dba22e52d490@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=apinski@marvell.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).