From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 09/10] gdb/python: Allow gdb.UnwindInfo to be created with non gdb.Value args
Date: Fri, 10 Mar 2023 17:38:38 +0200 [thread overview]
Message-ID: <83zg8ky5tt.fsf@gnu.org> (raw)
In-Reply-To: <9da6361cc56f184b6a44b1086d9fbeae6d30eab9.1678460067.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Fri, 10 Mar 2023 14:55:26 +0000)
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri, 10 Mar 2023 14:55:26 +0000
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>
> gdb/NEWS | 4 +
> gdb/doc/python.texi | 3 +-
> gdb/python/py-unwind.c | 113 ++++++++++++++-----------
> gdb/testsuite/gdb.python/py-unwind.exp | 36 ++++++++
> gdb/testsuite/gdb.python/py-unwind.py | 6 +-
> 5 files changed, 111 insertions(+), 51 deletions(-)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 0d9049ff134..c4f7de11c6e 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -130,6 +130,10 @@ show always-read-ctf
> - gdb.PendingFrame.function(): Return a gdb.Symbol for the
> current pending frame, or None.
>
> + ** The frame-id passed to gdb.PendingFrame.create_unwind_info can
> + now use either an integer or a gdb.Value object for each of its
> + 'sp', 'pc', and 'special' attributes.
> +
> *** Changes in GDB 13
>
> * MI version 1 is deprecated, and will be removed in GDB 14.
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 1c4239841af..3074b5250a3 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -2815,7 +2815,8 @@
> this.
> @end table
>
> -Each attribute value should be an instance of @code{gdb.Value}.
> +Each attribute value should either be an instance of @code{gdb.Value}
> +or an integer.
>
> @end defun
OK for the documentation parts, thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-03-10 15:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:55 [PATCH 00/10] Improvements & Cleanup For Python Unwinder API Andrew Burgess
2023-03-10 14:55 ` [PATCH 01/10] gdb/doc: spring clean the Python unwinders documentation Andrew Burgess
2023-03-10 15:24 ` Eli Zaretskii
2023-03-14 9:27 ` Andrew Burgess
2023-03-14 12:56 ` Eli Zaretskii
2023-03-16 14:30 ` Andrew Burgess
2023-03-10 14:55 ` [PATCH 02/10] gdb/python: make the gdb.unwinder.Unwinder class more robust Andrew Burgess
2023-03-10 15:32 ` Eli Zaretskii
2023-03-14 10:06 ` Andrew Burgess
2023-03-14 12:57 ` Eli Zaretskii
2023-03-31 2:15 ` Simon Marchi
2023-04-03 10:02 ` Andrew Burgess
2023-03-10 14:55 ` [PATCH 03/10] gdb/python: remove unneeded nullptr check in frapy_block Andrew Burgess
2023-03-10 14:55 ` [PATCH 04/10] gdb/python: add PENDING_FRAMEPY_REQUIRE_VALID macro in py-unwind.c Andrew Burgess
2023-03-10 14:55 ` [PATCH 05/10] gdb/python: add some additional methods to gdb.PendingFrame Andrew Burgess
2023-03-10 15:42 ` Eli Zaretskii
2023-03-14 10:18 ` Andrew Burgess
2023-03-14 12:59 ` Eli Zaretskii
2023-03-16 14:28 ` Andrew Burgess
2023-03-16 14:46 ` Eli Zaretskii
2023-03-16 17:26 ` Andrew Burgess
2023-03-16 19:54 ` Eli Zaretskii
2023-03-10 14:55 ` [PATCH 06/10] gdb/python: add __repr__ for PendingFrame and UnwindInfo Andrew Burgess
2023-03-10 14:55 ` [PATCH 07/10] gdb/python: remove Py_TPFLAGS_BASETYPE from gdb.UnwindInfo Andrew Burgess
2023-03-10 14:55 ` [PATCH 08/10] gdb: have value_as_address call unpack_pointer Andrew Burgess
2023-03-10 15:28 ` Tom Tromey
2023-03-10 22:08 ` Andrew Burgess
2023-03-10 14:55 ` [PATCH 09/10] gdb/python: Allow gdb.UnwindInfo to be created with non gdb.Value args Andrew Burgess
2023-03-10 15:34 ` Tom Tromey
2023-03-10 22:16 ` Andrew Burgess
2023-03-11 14:47 ` Tom Tromey
2023-03-10 15:38 ` Eli Zaretskii [this message]
2023-03-10 14:55 ` [PATCH 10/10] gdb/python: Add new gdb.unwinder.FrameId class Andrew Burgess
2023-03-10 15:36 ` Eli Zaretskii
2023-03-14 10:58 ` Andrew Burgess
2023-03-14 13:00 ` Eli Zaretskii
2023-03-29 16:27 ` [PATCH 00/10] Improvements & Cleanup For Python Unwinder API Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zg8ky5tt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).