Re: [PATCH 09/10] gdb/python: Allow gdb.UnwindInfo to be created with non gdb.Value args

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Currently all of these frame-id attributes need to be gdb.Value
> Andrew> objects, but the only reason for that requirement is that we have some
> Andrew> code in py-unwind.c that only handles gdb.Value objects.
>
> Andrew> If instead we switch to using get_addr_from_python in py-utils.c then
> Andrew> we will support both gdb.Value objects and also raw numbers, which
> Andrew> might make things simpler in some cases.
>
> FWIW this was https://sourceware.org/bugzilla/show_bug.cgi?id=19314
> which I closed for reasons I no longer really understand.

That would indeed appear to be a similar issue, but it's not the exact
same problem - at least, the code mentioned in that bug isn't touched by
this series.

This patch is specifically about the frame-id object which needs to be
passed to the PendingFrame.create_unwind_info call.  That frame-id
object needs to have 'sp' and 'pc' attributes, which previously had to
be gdb.Value objects, but can now be raw integers.

The code mentioned in that bug is for the
UnwindInfo.add_saved_register method, which takes a register-id and a
register value, the value, it would seem, also has to be a gdb.Value.

I haven't tried to change that, but I could take a look.

Thanks,
Andrew