public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add attributes and methods to gdb.Inferior
Date: Wed, 17 May 2023 09:45:45 -0600	[thread overview]
Message-ID: <87a5y30xna.fsf@tromey.com> (raw)
In-Reply-To: <83y1lxa3c4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 May 2023 19:15:23 +0300")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> +The environment that will be passed to the inferior can be changed
>> +from Python.  These methods only take effect when the inferior is

Eli> "These methods" seems to allude to something that was described
Eli> before, but there's nothing.  So I would suggest either

Eli>   The methods described below only take effect when...

Eli> or

Eli>   The environment that will be passed to the inferior can be changed
Eli>   from Python by using the following methods.  These methods only take
Eli>   effect when...

I made this change in v2.

Eli> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

Tom

  reply	other threads:[~2023-05-17 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 16:01 [PATCH 0/2] Add more DAP launch parameters Tom Tromey
2023-05-09 16:01 ` [PATCH 1/2] Add attributes and methods to gdb.Inferior Tom Tromey
2023-05-09 16:15   ` Eli Zaretskii
2023-05-17 15:45     ` Tom Tromey [this message]
2023-05-10 10:17   ` Andrew Burgess
2023-05-17 15:32     ` Tom Tromey
2023-05-09 16:02 ` [PATCH 2/2] Add "args" and "env" parameters to DAP launch request Tom Tromey
2023-05-09 16:10   ` Eli Zaretskii
2023-05-16 19:06     ` Tom Tromey
2023-05-16 19:10       ` Eli Zaretskii
2023-05-16 19:20         ` Eli Zaretskii
2023-05-10 12:39   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5y30xna.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).