Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 16 May 2023 22:10:54 +0300
> Cc: gdb-patches@sourceware.org
> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
>  DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
>  RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
>  T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
> From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
> 
> > From: Tom Tromey <tromey@adacore.com>
> > Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
> > Date: Tue, 16 May 2023 13:06:09 -0600
> > 
> > >> +@item env
> > >> +If provided, this should be an object where each value is a string.
> > 
> > Eli> This doesn't say what should those string values be.  Shouldn't they
> > Eli> be of the format "@var{variable}=@var{value}"?
> > 
> > In JSON an object is a dictionary; so the keys are strings and the
> > values are as well.  That is it looks like {"variable": "value"}
> 
> That's okay, but I think we should say something about the structure
> of those strings, and {"variable": "value"} goes a long way towards
           ^^^^^^^
That should have been "objects", sorry.

> that.