From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request
Date: Tue, 16 May 2023 22:10:54 +0300 [thread overview]
Message-ID: <835y8sytvl.fsf@gnu.org> (raw)
In-Reply-To: <87pm7014gu.fsf@tromey.com> (message from Tom Tromey on Tue, 16 May 2023 13:06:09 -0600)
> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
> Date: Tue, 16 May 2023 13:06:09 -0600
>
> >> +@item env
> >> +If provided, this should be an object where each value is a string.
>
> Eli> This doesn't say what should those string values be. Shouldn't they
> Eli> be of the format "@var{variable}=@var{value}"?
>
> In JSON an object is a dictionary; so the keys are strings and the
> values are as well. That is it looks like {"variable": "value"}
That's okay, but I think we should say something about the structure
of those strings, and {"variable": "value"} goes a long way towards
that.
next prev parent reply other threads:[~2023-05-16 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:01 [PATCH 0/2] Add more DAP launch parameters Tom Tromey
2023-05-09 16:01 ` [PATCH 1/2] Add attributes and methods to gdb.Inferior Tom Tromey
2023-05-09 16:15 ` Eli Zaretskii
2023-05-17 15:45 ` Tom Tromey
2023-05-10 10:17 ` Andrew Burgess
2023-05-17 15:32 ` Tom Tromey
2023-05-09 16:02 ` [PATCH 2/2] Add "args" and "env" parameters to DAP launch request Tom Tromey
2023-05-09 16:10 ` Eli Zaretskii
2023-05-16 19:06 ` Tom Tromey
2023-05-16 19:10 ` Eli Zaretskii [this message]
2023-05-16 19:20 ` Eli Zaretskii
2023-05-10 12:39 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y8sytvl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).