Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 09 May 2023 10:02:00 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> 
> This patch augments the DAP launch request with some optional new
> parameters that let the client control the command-line arguments and
> the environment of the inferior.
> ---
>  gdb/doc/gdb.texinfo                | 13 +++++-
>  gdb/python/lib/gdb/dap/launch.py   | 20 ++++++++-
>  gdb/testsuite/gdb.dap/args-env.c   | 28 ++++++++++++
>  gdb/testsuite/gdb.dap/args-env.exp | 90 ++++++++++++++++++++++++++++++++++++++
>  gdb/testsuite/lib/dap-support.exp  | 39 +++++++++++++----
>  5 files changed, 178 insertions(+), 12 deletions(-)

Thanks.

> +@item env
> +If provided, this should be an object where each value is a string.

This doesn't say what should those string values be.  Shouldn't they
be of the format "@var{variable}=@var{value}"?

> +The environment of the inferior will be set to exactly as passed in,
> +as if by a sequence of invocations of @code{set environment} and
> +@code{unset environment}.  @xref{Environment}.

This could potentially confuse: if this is equivalent to "set
environment", then the variables are _added_ to the one inherited from
the parent process, no?  Also, when would this be equivalent to "unset
environment"?

Reviewed-By: Eli Zaretskii <eliz@gnu.org>