From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line
Date: Tue, 20 Dec 2022 14:06:13 -0700 [thread overview]
Message-ID: <87a63hkcoq.fsf@tromey.com> (raw)
In-Reply-To: <20221122113319.1760546-2-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Tue, 22 Nov 2022 12:33:19 +0100")
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
Bruno> +/* Read the DW_ATTR_decl_line attribute for the given DIE in the
Bruno> + given CU. If the format is not recognized or the attribute is
Bruno> + not present, set it to 0. */
Bruno> +
Bruno> +static unsigned int
Bruno> +read_decl_line (struct die_info *die, struct dwarf2_cu *cu)
Bruno> +{
Bruno> +
Bruno> + struct attribute *decl_line = dwarf2_attr (die, DW_AT_decl_line, cu);
There's a spurious blank line here.
Ok with this fixed.
Tom
next prev parent reply other threads:[~2022-12-20 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:33 [PATCH v3 0/2] Improve handling of using directives Bruno Larsen
2022-11-22 11:33 ` [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line Bruno Larsen
[not found] ` <CAJVr-EMEbyP4pgDk=U50p5nWrybJgFbdZ0iLCp4W6WbWJKGc9A@mail.gmail.com>
2022-12-15 13:26 ` Fwd: " Alexandra Petlanova Hajkova
2022-12-15 14:50 ` Bruno Larsen
2022-12-20 21:06 ` Tom Tromey [this message]
2022-11-22 11:33 ` [PATCH v3 2/2] gdb/c++: Detect ambiguous variables in imported namespaces Bruno Larsen
2022-12-20 21:10 ` Tom Tromey
2022-12-07 13:53 ` [PATCH v3 0/2] Improve handling of using directives Bruno Larsen
2022-12-15 10:17 ` [PINGv2][PATCH " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a63hkcoq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).