Re: Fwd: [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line

[Bruno Larsen <blarsen@redhat.com>]

On 15/12/2022 14:26, Alexandra Petlanova Hajkova via Gdb-patches wrote:
> On Tue, Nov 22, 2022 at 12:52 PM Bruno Larsen via Gdb-patches <
> gdb-patches@sourceware.org> wrote:
>
>>
>> Finally, because the final test of gdb.cp/nsusing.exp has turned into
>> multiple that all would need XFAILs for older GCCs (<= 4.3), and that
>> GCC is very old, if it is detected, the test just exits early.
>>
> I suggest using shorter sentences in general and I think the last sentence
> needs
> to be split in two. I had to read it 3 times to fully understand it.

Hi Sasha,

Thanks for the review! I'll try to keep my sentences short in the 
future. What do you think about changing the last paragraph to:

Finally, more tests were added to the end of gdb.cp/nsusing.exp. 
However, GCC version 4.3 or older already had troubles with the original 
test. If we detect that one of those old GCCs are used the test will 
just exit early instead of add many XFAILs.

-- 
Cheers,
Bruno