public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: Bruno Larsen <blarsen@redhat.com>,
	Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Subject: [PINGv2][PATCH v3 0/2] Improve handling of using directives
Date: Thu, 15 Dec 2022 11:17:56 +0100	[thread overview]
Message-ID: <b6829179-010b-1aad-9e7c-432cb01f725f@redhat.com> (raw)
In-Reply-To: <0d3c9d9a-a55c-e137-2a80-bf23f7866ce8@redhat.com>

Ping!
On 07/12/2022 14:53, Bruno Larsen wrote:
> Ping!
>
>
> -- 
> Cheers,
> Bruno
>
> On 22/11/2022 12:33, Bruno Larsen wrote:
>> This series tries to fix two of the main issues I saw when trying to get
>> gdb.cp/nsusing.exp working with clang. The first issue was that GDB
>> wouldn't care about when the 'using' directive happened in the code,
>> even if we were stopped before it, it was considered valid. The second
>> was that GDB would find the first reasonable variable in the imported
>> declarations and leave early, not caring about whether that variable was
>> ambiguous or not. Each of my patches fixes one of those issues.
>>
>> Changelog for v3:
>>   * changed map key to use std::string, so we get an ordered output.
>>   * Improved documentation on some spots
>>   * Fix bug where gdb could return a partial list of the ambiguous 
>> symbols
>>
>> Changelog for v2:
>>   * factored out some code to avoid unnecessary repetition.
>>   * made it so ambiguous variables are explicitly reported
>>   * fixed formatting issues.
>>
>> Bruno Larsen (2):
>>    gdb/c++: validate 'using' directives based on the current line
>>    gdb/c++: Detect ambiguous variables in imported namespaces
>>
>>   gdb/cp-namespace.c               | 99 ++++++++++++++++++++++++--------
>>   gdb/dwarf2/read.c                | 30 +++++++++-
>>   gdb/namespace.c                  | 25 ++++++++
>>   gdb/namespace.h                  | 16 +++++-
>>   gdb/testsuite/gdb.cp/nsusing.cc  |  3 +-
>>   gdb/testsuite/gdb.cp/nsusing.exp | 25 +++++++-
>>   6 files changed, 167 insertions(+), 31 deletions(-)


-- 
Cheers,
Bruno


      reply	other threads:[~2022-12-15 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 11:33 [PATCH " Bruno Larsen
2022-11-22 11:33 ` [PATCH v3 1/2] gdb/c++: validate 'using' directives based on the current line Bruno Larsen
     [not found]   ` <CAJVr-EMEbyP4pgDk=U50p5nWrybJgFbdZ0iLCp4W6WbWJKGc9A@mail.gmail.com>
2022-12-15 13:26     ` Fwd: " Alexandra Petlanova Hajkova
2022-12-15 14:50       ` Bruno Larsen
2022-12-20 21:06   ` Tom Tromey
2022-11-22 11:33 ` [PATCH v3 2/2] gdb/c++: Detect ambiguous variables in imported namespaces Bruno Larsen
2022-12-20 21:10   ` Tom Tromey
2022-12-07 13:53 ` [PATCH v3 0/2] Improve handling of using directives Bruno Larsen
2022-12-15 10:17   ` Bruno Larsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6829179-010b-1aad-9e7c-432cb01f725f@redhat.com \
    --to=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).