public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: Tom Tromey <tromey@adacore.com>,  Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Update the 'g' packet documentation
Date: Thu, 16 Feb 2023 11:16:31 -0700	[thread overview]
Message-ID: <87cz69pjb4.fsf@tromey.com> (raw)
In-Reply-To: <459e115b-5dff-2e37-46aa-9e8e7495536a@palves.net> (Pedro Alves's message of "Thu, 16 Feb 2023 17:10:38 +0000")

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

>> While I agree with that, it's also the case that tdep code can reject
>> such a description, and we ran into a case like this in the wild --
>> where a gdbserver does not report a register, causing i386-tdep to
>> reject the description.  However, at one point AdaCore had a port for
>> this target, and that port reported the register but sent back 'x' --
>> which worked.

Pedro> Curious.  It sounds like we made some register in a tdesc feature
Pedro> mandatory, even after the tdesc feature existed in previous
Pedro> releases?  That shouldn't have happened.

No, we are in the clear, what happened is that a vendor out there hacked
gdbserver to drop a register (the x86 "fop" register) for reasons we do
not know.  They also hacked their gdb to accept this.

AdaCore also had a patch for this target's gdbserver to not supply "fop"
(the kernel, mysteriously, does not make it available) -- but did not
change the XML or gdb, instead having the register report as
unavailable.

Tom

      reply	other threads:[~2023-02-16 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 18:37 [PATCH] " Tom Tromey
2023-01-11 19:56 ` Eli Zaretskii
2023-01-13 12:09 ` Pedro Alves
2023-01-13 18:58   ` Tom Tromey
2023-01-27 15:25     ` [PATCH v2] " Pedro Alves
2023-01-27 16:15       ` Eli Zaretskii
2023-01-30 21:15       ` Tom Tromey
2023-02-16 17:10         ` Pedro Alves
2023-02-16 18:16           ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz69pjb4.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).