From: Tom Tromey <tom@tromey.com>
To: Torbjorn SVENSSON via Gdb-patches <gdb-patches@sourceware.org>
Cc: Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>,
<luis.machado@arm.com>, <vanekt@volny.cz>,
Yvan Roux <yvan.roux@foss.st.com>
Subject: Re: [PATCH v2 3/4] gdb: dwarf2 generic implementation for caching function data
Date: Tue, 20 Dec 2022 14:04:07 -0700 [thread overview]
Message-ID: <87edstkcs8.fsf@tromey.com> (raw)
In-Reply-To: <549c9c1f-769e-df9a-6c39-969c1eb7eb06@foss.st.com> (Torbjorn SVENSSON via Gdb-patches's message of "Fri, 18 Nov 2022 17:01:50 +0100")
>>>>> "Torbjorn" == Torbjorn SVENSSON via Gdb-patches <gdb-patches@sourceware.org> writes:
>> + fn_data = FRAME_OBSTACK_ZALLOC (struct dwarf2_frame_fn_data);
>> + fn_data->fn = fn;
>> + fn_data->data = frame_obstack_zalloc (size);
Torbjorn> Since these 2 blocks (fn_data and fn_data->fn) are allocated on the
Torbjorn> obstack, do we need to release them in dwarf2_frame_dealloc_cache() or
Torbjorn> just leave them to the generic garbage collection?
They can just be left. The obstack as a whole is destroyed at once.
However, you probably should consider the lifetime management of the
data that's attached to the frame. That said, it's fine if the answer
is that they should be allocated on the obstack as well.
Tom
next prev parent reply other threads:[~2022-12-20 21:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:52 [PATCH 0/4] v2 gdb/arm: Fixes for Cortex-M stack unwinding Torbjörn SVENSSON
2022-11-18 15:52 ` [PATCH v2 1/4] gdb/arm: Update active msp/psp when switching stack Torbjörn SVENSSON
2022-11-21 14:04 ` Luis Machado
2022-11-18 15:52 ` [PATCH v2 2/4] gdb/arm: Ensure that stack pointers are in sync Torbjörn SVENSSON
2022-11-21 14:04 ` Luis Machado
2022-11-18 15:52 ` [PATCH v2 3/4] gdb: dwarf2 generic implementation for caching function data Torbjörn SVENSSON
2022-11-18 16:01 ` Torbjorn SVENSSON
2022-12-20 21:04 ` Tom Tromey [this message]
2022-11-21 21:16 ` Luis Machado
2022-11-29 15:19 ` Torbjorn SVENSSON
2022-11-29 16:24 ` Tomas Vanek
2022-11-30 10:16 ` Torbjorn SVENSSON
2022-11-30 10:19 ` Luis Machado
2022-12-08 1:11 ` Luis Machado
2022-12-19 19:28 ` [PING] " Torbjorn SVENSSON
2022-12-20 21:02 ` Tom Tromey
2022-12-28 16:16 ` Torbjorn SVENSSON
2023-01-05 20:53 ` Torbjorn SVENSSON
2023-01-14 6:54 ` Joel Brobecker
2023-01-18 18:47 ` Tom Tromey
2023-01-19 10:31 ` Torbjorn SVENSSON
2022-11-18 15:52 ` [PATCH v2 4/4] gdb/arm: Use new dwarf2 function cache Torbjörn SVENSSON
2022-11-21 21:04 ` Luis Machado
2022-11-29 15:19 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edstkcs8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=torbjorn.svensson@foss.st.com \
--cc=vanekt@volny.cz \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).