Re: [PATCH 3/3] Don't let gdb_stdlog use pager

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

>> diff --git a/gdb/cli/cli-interp.h b/gdb/cli/cli-interp.h
>> index fa007d78621..978e7f291e4 100644
>> --- a/gdb/cli/cli-interp.h
>> +++ b/gdb/cli/cli-interp.h
>> @@ -42,6 +42,7 @@ class cli_interp_base : public interp
>> ui_file *targ;
>> ui_file *targerr;
>> ui_file_up tee_to_delete;
>> +    ui_file_up stderr_to_delete;
>> ui_file_up file_to_delete;
>> ui_file_up log_to_delete;

Simon> I think it would help me understand if the naming of these fields was a
Simon> bit better.  I think the to_delete suffixes are no longer relevant
Simon> since using ui_file_up, the types tell us about the ownership.  And I
Simon> think that "tee_to_delete" could be named "stdout_tee", and
Simon> "stderr_to_delete" could be named "stderr_tee".

Simon> Not terribly important, perhaps as a follow up.

I'll send a follow-up for this as well.

Tom