From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>, Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH 2/3] Don't let tee_file own a stream
Date: Mon, 28 Nov 2022 13:29:49 -0700 [thread overview]
Message-ID: <87k03eom9u.fsf@tromey.com> (raw)
In-Reply-To: <a22670c0-2bff-247c-0893-9139d2ed57ac@simark.ca> (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 14:18:28 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>> + mi->saved_tee_to_delete = nullptr;
Simon> Should the two _to_delete ones be ui_file_ups?
It would be better. I'll add on a patch to do this.
Simon> Otherwise, everything related to logging / redirection confuse me, so I
Simon> can't really comment on the change itself.
It's a real mess.
Tom
next prev parent reply other threads:[~2022-11-28 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:29 [PATCH 0/3] Do not let logging use pager Tom Tromey
2022-11-17 18:29 ` [PATCH 1/3] Remove 'saved_output' global Tom Tromey
2022-11-17 18:29 ` [PATCH 2/3] Don't let tee_file own a stream Tom Tromey
2022-11-28 19:18 ` Simon Marchi
2022-11-28 20:29 ` Tom Tromey [this message]
2022-11-17 18:29 ` [PATCH 3/3] Don't let gdb_stdlog use pager Tom Tromey
2022-11-28 19:23 ` Simon Marchi
2022-11-28 20:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k03eom9u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).