From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 10/16] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes
Date: Thu, 27 Jul 2023 22:01:38 -0300 [thread overview]
Message-ID: <87jzuk7sst.fsf@linaro.org> (raw)
In-Reply-To: <20230630134616.1238105-11-luis.machado@arm.com>
Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
> case AARCH64_SVE_MAGIC:
> {
> /* Check if the section is followed by a full SVE dump, and set
> sve_regs if it is. */
> gdb_byte buf[4];
> - uint16_t flags;
> -
> - if (!tdep->has_sve ())
> - break;
>
> + /* Extract the vector length. */
> if (target_read_memory (section + AARCH64_SVE_CONTEXT_VL_OFFSET,
> buf, 2) != 0)
> {
> + warning (_("Failed to read the vector length from the SVE "
> + " signal frame context."));
Extraneous space between "SVE" and "signal".
> section += size;
> break;
> }
> case AARCH64_ZA_MAGIC:
> {
> - if (!tdep->has_sme ())
> - {
> - section += size;
> - break;
> - }
> -
> /* Check if the section is followed by a full ZA dump, and set
> za_state if it is. */
> gdb_byte buf[2];
>
> + /* Extract the streaming vector length. */
> if (target_read_memory (section + AARCH64_SVE_CONTEXT_VL_OFFSET,
Same comment from the previous patch about using the SME macro instead
of the SVE one.
> buf, 2) != 0)
> {
> + warning (_("Failed to read the streaming vector length from "
> + " ZA signal frame context."));
Extraneous space between "SVE" and "signal".
> section += size;
> break;
> }
> @@ -477,11 +499,49 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self,
> if (!extra_found && section > section_end)
> break;
> }
> +}
> +
> +/* Implement the "init" method of struct tramp_frame. */
> +
> +static void
> +aarch64_linux_sigframe_init (const struct tramp_frame *self,
> + frame_info_ptr this_frame,
> + struct trad_frame_cache *this_cache,
> + CORE_ADDR func)
> +{
> + /* Read the signal context information. */
> + struct aarch64_linux_sigframe signal_frame;
> + aarch64_linux_read_signal_frame_info (this_frame, signal_frame);
> +
> + /* Now we have all the data required to restore the registers from the
> + signal frame. */
> +
> + /* Restore the general purpose registers. */
> + CORE_ADDR offset
> + = signal_frame.sigcontext_address + AARCH64_SIGCONTEXT_XO_OFFSET;
You can simplify the above to
CORE_ADDR offset = signal_frame.gpr_section;
> + for (int i = 0; i < 31; i++)
> + {
> + trad_frame_set_reg_addr (this_cache, AARCH64_X0_REGNUM + i, offset);
> + offset += AARCH64_SIGCONTEXT_REG_SIZE;
> + }
> + trad_frame_set_reg_addr (this_cache, AARCH64_SP_REGNUM, offset);
> + offset += AARCH64_SIGCONTEXT_REG_SIZE;
> + trad_frame_set_reg_addr (this_cache, AARCH64_PC_REGNUM, offset);
> diff --git a/gdb/tramp-frame.h b/gdb/tramp-frame.h
> index fa0241acb2d..563c34ae595 100644
> --- a/gdb/tramp-frame.h
> +++ b/gdb/tramp-frame.h
> @@ -42,6 +42,13 @@ struct trad_frame_cache;
> instruction sequence. */
> #define TRAMP_SENTINEL_INSN ULONGEST_MAX
>
> +/* Assuming the frame chain: (outer) prev <-> this <-> next (inner);
> + use THIS frame, and implicitly the NEXT frame's register unwind
> + method, return PREV frame's architecture. */
Maybe s/return/to return/ ?
> +
> +typedef struct gdbarch *(frame_prev_arch_ftype) (frame_info_ptr this_frame,
> + void **this_prologue_cache);
> +
> struct tramp_frame
> {
> /* The trampoline's type, some a signal trampolines, some are normal
> @@ -75,6 +82,11 @@ struct tramp_frame
> int (*validate) (const struct tramp_frame *self,
> frame_info_ptr this_frame,
> CORE_ADDR *pc);
> +
> + /* Given the current frame in THIS_FRAME and a frame cache in FRAME_CACHE,
> + return the architecture of the previous frame. */
> + struct gdbarch *(*prev_arch) (frame_info_ptr this_frame,
> + void **frame_cache);
Shouldn't the typedef defined above be used here?
> };
--
Thiago
next prev parent reply other threads:[~2023-07-28 1:01 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 13:46 [PATCH v3 00/16] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
2023-06-30 13:46 ` [PATCH v3 01/16] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Luis Machado
2023-07-24 15:53 ` Thiago Jung Bauermann
2023-07-24 16:26 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 02/16] [gdb/aarch64] refactor: Rename SVE-specific files Luis Machado
2023-06-30 13:46 ` [PATCH v3 03/16] [gdb/gdbserver] refactor: Simplify SVE interface to read/write registers Luis Machado
2023-07-24 16:19 ` Thiago Jung Bauermann
2023-07-25 9:28 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 04/16] [gdb/aarch64] sve: Fix return command when using V registers in a SVE-enabled target Luis Machado
2023-06-30 13:46 ` [PATCH v3 05/16] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Luis Machado
2023-07-26 20:01 ` Thiago Jung Bauermann
2023-07-27 9:01 ` Luis Machado
2023-07-28 1:19 ` Thiago Jung Bauermann
2023-06-30 13:46 ` [PATCH v3 06/16] [gdbserver/aarch64] refactor: Adjust expedited registers dynamically Luis Machado
2023-06-30 13:46 ` [PATCH v3 07/16] [gdbserver/aarch64] sme: Add support for SME Luis Machado
2023-07-27 19:41 ` Thiago Jung Bauermann
2023-06-30 13:46 ` [PATCH v3 08/16] [gdb/aarch64] sve: Fix signal frame z/v register restore Luis Machado
2023-07-27 21:52 ` Thiago Jung Bauermann
2023-07-31 12:22 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 09/16] [gdb/aarch64] sme: Signal frame support Luis Machado
2023-07-27 22:25 ` Thiago Jung Bauermann
2023-07-31 12:23 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 10/16] [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes Luis Machado
2023-07-28 1:01 ` Thiago Jung Bauermann [this message]
2023-07-31 12:27 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 11/16] [gdb/aarch64] sme: Support TPIDR2 signal frame context Luis Machado
2023-06-30 13:46 ` [PATCH v3 12/16] [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping register state to core files Luis Machado
2023-06-30 13:46 ` [PATCH v3 13/16] [gdb/generic] corefile/bug: Fixup (gcore) core file target description reading order Luis Machado
2023-07-28 3:12 ` Thiago Jung Bauermann
2023-07-31 11:38 ` Luis Machado
2023-09-05 8:28 ` Luis Machado
2023-06-30 13:46 ` [PATCH v3 14/16] [gdb/aarch64] sme: Core file support for Linux Luis Machado
2023-08-03 0:18 ` Thiago Jung Bauermann
2023-08-03 11:37 ` Luis Machado
2023-08-04 20:45 ` Thiago Jung Bauermann
2023-06-30 13:46 ` [PATCH v3 15/16] [gdb/testsuite] sme: Add SVE/SME testcases Luis Machado
2023-08-04 0:59 ` Thiago Jung Bauermann
2023-08-11 15:42 ` Luis Machado
2023-08-12 0:42 ` Thiago Jung Bauermann
2023-06-30 13:46 ` [PATCH v3 16/16] [gdb/docs] sme: Document SME registers and features Luis Machado
2023-07-01 8:58 ` Eli Zaretskii
2023-07-03 9:52 ` Luis Machado
2023-07-03 12:03 ` Eli Zaretskii
2023-07-03 12:06 ` Luis Machado
2023-07-17 11:40 ` [PING][PATCH v3 00/16] SME support for AArch64 gdb/gdbserver on Linux Luis Machado
2023-07-24 8:15 ` Luis Machado
2023-08-04 21:24 ` [PATCH " Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzuk7sst.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).