Re: [PATCH 2/4] Add DAP log level parameter

["Kévin Le Gouguec" <legouguec@adacore.com>]

Tom Tromey <tromey@adacore.com> writes:

> +# Logging levels.
> +LOG_DEFAULT = 1
> +LOG_FULL = 2
> +
> +
> +class LogLevel(gdb.Parameter):
> +    """DAP logging level."""
> +
> +    set_doc = "Set the DAP logging level."
> +    show_doc = "Show the DAP logging level."
> +
> +    def __init__(self):
> +        super().__init__(
> +            "debug dap-log-level", gdb.COMMAND_MAINTENANCE, gdb.PARAM_ZUINTEGER
> +        )
> +        self.value = LOG_DEFAULT
> +
> +
> +_log_level = LogLevel()

I might suggest an enum here:

    from enum import IntEnum, auto

    class LogLevel(IntEnum):
        DEFAULT = auto()
        FULL = auto()

    class LogLevelParam(gdb.Parameter):
        """..."""
        def __init__(self):
            ...
            self.value = LogLevel.DEFAULT

But the benefits of Python enums are somewhat marginal (even more so in
this instance; FWIW I _think_ IntEnum & auto are all available since
3.4), so no strong feelings about this.

Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com>