Re: [PATCH 0/4] Check for rogue DAP exceptions

["Kévin Le Gouguec" <legouguec@adacore.com>]

Tom Tromey <tromey@adacore.com> writes:

> While looking into a question I got about DAP, I found out that the
> DAP 'attach' test had some unexpected exceptions in the log file,
> caused by an incorrect assumption in the stop event listener.
>
> This series tries to make the DAP implementation a bit more robust.
> After these patches, exceptions that are expected in the normal course
> of operation are not logged by default.  Then, the test suite is
> updated to check that no rogue exceptions are seen.
>
> ---
> Tom Tromey (4):
>       Introduce and use DAPException
>       Add DAP log level parameter
>       Avoid exception from attach in DAP
>       Check for rogue DAP exceptions in test suite
>
>  gdb/NEWS                             |  5 ++++
>  gdb/doc/gdb.texinfo                  | 18 ++++++++++++++
>  gdb/python/lib/gdb/dap/breakpoint.py | 12 ++++++---
>  gdb/python/lib/gdb/dap/evaluate.py   | 12 ++++-----
>  gdb/python/lib/gdb/dap/events.py     | 43 ++++++++++++++++++++++++++-------
>  gdb/python/lib/gdb/dap/launch.py     |  7 +++---
>  gdb/python/lib/gdb/dap/server.py     | 10 ++++++++
>  gdb/python/lib/gdb/dap/sources.py    |  6 ++---
>  gdb/python/lib/gdb/dap/startup.py    | 47 +++++++++++++++++++++++++++++++++---
>  gdb/python/lib/gdb/dap/varref.py     |  6 ++---
>  gdb/testsuite/lib/dap-support.exp    | 34 +++++++++++++++++++++++++-
>  11 files changed, 167 insertions(+), 33 deletions(-)
> ---

Left a couple of comments on some of the patches, but the series could
go in as-is IMO 👌

Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com>