public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Add DAP log level parameter
Date: Thu, 14 Dec 2023 12:02:45 -0700	[thread overview]
Message-ID: <87v8908v56.fsf@tromey.com> (raw)
In-Reply-To: <838r5ztgdv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 20:39:08 +0200")

>> +@table @code
>> +@item set debug dap-log-file @r{[}@var{filename}@r{]}
>> +Enable DAP logging.  Logs are written to the specified file.  If no
>> +file is given, logging is stopped.

Eli> I suggest to use "@var{filename}" instead of "file" here, on both
Eli> occasions.

I made this change.

Tom

  reply	other threads:[~2023-12-14 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 17:44 [PATCH 0/4] Check for rogue DAP exceptions Tom Tromey
2023-12-12 17:44 ` [PATCH 1/4] Introduce and use DAPException Tom Tromey
2023-12-12 17:44 ` [PATCH 2/4] Add DAP log level parameter Tom Tromey
2023-12-12 18:39   ` Eli Zaretskii
2023-12-14 19:02     ` Tom Tromey [this message]
2023-12-13 16:35   ` Kévin Le Gouguec
2023-12-14 19:06     ` Tom Tromey
2023-12-12 17:44 ` [PATCH 3/4] Avoid exception from attach in DAP Tom Tromey
2023-12-13 16:36   ` Kévin Le Gouguec
2023-12-14 18:52     ` Tom Tromey
2023-12-12 17:44 ` [PATCH 4/4] Check for rogue DAP exceptions in test suite Tom Tromey
2023-12-13 16:36 ` [PATCH 0/4] Check for rogue DAP exceptions Kévin Le Gouguec
2023-12-22 16:57 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8908v56.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).