Re: [PATCH 2/4] Add DAP log level parameter

[Eli Zaretskii <eliz@gnu.org>]

> From: Tom Tromey <tromey@adacore.com>
> Date: Tue, 12 Dec 2023 10:44:43 -0700
> 
> This adds a new parameter to control the DAP logging level.  By
> default, "expected" exceptions are not logged, but the parameter lets
> the user change this when more logging is desired.
> 
> This also changes a couple of spots to avoid logging the stack trace
> for a DAPException.
> 
> This patch also documents the existing DAP logging parameter.  I
> forgot to document this before.
> ---
>  gdb/NEWS                             |  5 +++++
>  gdb/doc/gdb.texinfo                  | 18 ++++++++++++++++++
>  gdb/python/lib/gdb/dap/breakpoint.py |  6 ++++--
>  gdb/python/lib/gdb/dap/server.py     | 10 ++++++++++
>  gdb/python/lib/gdb/dap/startup.py    | 29 +++++++++++++++++++++++++----
>  5 files changed, 62 insertions(+), 6 deletions(-)

Thanks, the documentation parts are okay, with one comment:

> +@table @code
> +@item set debug dap-log-file @r{[}@var{filename}@r{]}
> +Enable DAP logging.  Logs are written to the specified file.  If no
> +file is given, logging is stopped.

I suggest to use "@var{filename}" instead of "file" here, on both
occasions.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>