Re: [PATCH V4] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Carl Love <cel@us.ibm.com> wrote:

>+# Move to the function pointer call to void_func so we will use the GEP
>+# to enter void_func and break.
>+set breakloc [gdb_get_line_number "FUNCTION PTR" "$srcfile"]
>+gdb_test "break $breakloc" \
>+    "Breakpoint $decimal at .*$srcfile, line $breakloc\." \
>+    "set breakpoint on funp"
>+gdb_continue_to_breakpoint "funp call" ".*$srcfile:$breakloc.*"

Do we still need this?  In the new source file, there is only
a single call to void_func (via function pointer), so the
tbreak below should already stop there:

> set breakloc [gdb_get_line_number "VOID FUNC" "$srcfile"]
> gdb_test "tbreak void_func" \
>     "Temporary breakpoint $decimal at .*$srcfile, line $breakloc\." \


>+int
>+callee() {		/* ENTER CALLEE */
>+  return myglob++;	/* ARRIVED IN CALLEE */
>+}			/* RETURN FROM CALLEE */

These comment markers seem to be nowhere used.

+   exit (0);      /* end of main */

Comment marker should be all-upper-case like the others.

>+# Move to the function pointer call to the callee call after the function
>+# pointer call to callee to begin the test.  The function pointer call to
>+# callee will use the Global Entry Point on Power.

This comment seems confusing.

Bye,
Ulrich