From: Zoran Zaric <zoran.zaric@amd.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 16/28] Change DWARF stack to use new dwarf_entry classes
Date: Thu, 4 Nov 2021 12:43:37 +0000 [thread overview]
Message-ID: <94c0be81-7bcd-313d-acf5-8610e3a0e7ed@amd.com> (raw)
In-Reply-To: <20211031175848.ctfdetybhttrgao4@ubuntu.lan>
>> +
>> + dwarf_location *location = dynamic_cast<dwarf_location *> (entry.get ());
>> + gdb_assert (location != nullptr);
>> +
>> + return location->to_value (address_type);
>> +}
>> +
>> +/* Set of functions that perform different arithmetic operations
>> + on a given DWARF value arguments.
>
> Maybe use 'on dwarf_value arguments.' (otherwise the 'a' and 'arguments'
> seems strange to me).
>
I see what you mean. Thanks.
>> +
>> + Currently the existing struct value operations are used under the
>> + hood to avoid the code duplication. Vector types are planned to be
>> + promoted to base types in the future anyway which means that the
>> + operations subset needed is just going to grow anyway. */
>> +
>> +/* Compare two DWARF value's ARG1 and ARG2 for equality in a context
>> + of a value entry comparison. */
>> +
>> +static bool
>> +dwarf_value_equal_op (dwarf_value &arg1, dwarf_value &arg2)
>> +{
>> + struct value *arg1_value = arg1.to_gdb_value (arg1.type ());
>> + struct value *arg2_value = arg2.to_gdb_value (arg2.type ());
>> + return value_equal (arg1_value, arg2_value);
>> +}
>> +
>> +/* Compare if DWARF value ARG1 is lesser then DWARF value ARG2 in a
>
> is lesser then -> is less than
>
The funny thing is that this was there in the original code and nobody
noticed until now. Thanks.
>> diff --git a/gdb/dwarf2/expr.h b/gdb/dwarf2/expr.h
>> index 16c5e710ff5..aaae381f4fe 100644
>> --- a/gdb/dwarf2/expr.h
>> +++ b/gdb/dwarf2/expr.h
>> @@ -25,6 +25,22 @@
>> #include "leb128.h"
>> #include "gdbtypes.h"
>>
>> +/* Base class that describes entries found on a DWARF expression
>> + evaluation stack. */
>> +
>> +class dwarf_entry
>> +{
>> +public:
>> + /* Not expected to be called on it's own. */
>> + dwarf_entry () = default;
>
> This was mentioned in a earlier patch but I re-state it here because it
> is easy to miss it when reabasing since this part is temporarily moved
> from another file: this ctor could be turned protected.
>
Thank you for tracking it through the series for me :).
Like discussed on some previous patches (PATCH v3 6/28) comment threads,
I will also add a comment at the beginning of the expr.c file in this
patch to explain that the evaluator is using the HOST_CHAR_SIZE constant
instead the hard coded number 8 until there is a proper support for
different sizes bytes.
I was advised to use this constant by a maintainer Pedro Alves, because
the value of that constant is apparently always guaranteed to be 8.
Much appreciate it,
Zoran
next prev parent reply other threads:[~2021-11-04 12:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:32 [PATCH v3 00/28] Allow location description on the DWARF stack Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 01/28] Add new register access interface to expr.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 02/28] Add new memory " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 03/28] Add new classes that model DWARF stack element Zoran Zaric
2021-10-21 23:43 ` Lancelot SIX
2021-10-22 16:38 ` Zoran Zaric
2021-10-22 21:34 ` Lancelot SIX
2021-10-14 9:32 ` [PATCH v3 04/28] Add to_location method to DWARF entry classes Zoran Zaric
2021-10-22 21:21 ` Lancelot SIX
2021-10-25 21:23 ` Simon Marchi
2021-11-01 16:01 ` Zoran Zaric
2021-11-01 20:36 ` Simon Marchi
2021-11-01 16:00 ` Zoran Zaric
2021-11-01 17:48 ` Lancelot SIX
2021-10-14 9:32 ` [PATCH v3 05/28] Add to_value " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 06/28] Add read method to location description classes Zoran Zaric
2021-10-25 18:33 ` Lancelot SIX
2021-10-25 21:37 ` Simon Marchi
2021-11-02 14:26 ` Zoran Zaric
2021-11-03 19:03 ` Simon Marchi
2021-11-05 11:58 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 07/28] Add write " Zoran Zaric
2021-10-25 20:21 ` Lancelot SIX
2021-11-03 10:27 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 08/28] Add deref " Zoran Zaric
2021-10-25 22:31 ` Lancelot SIX
2021-11-03 10:51 ` Zoran Zaric
2021-11-03 17:37 ` Simon Marchi
2021-11-05 11:55 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 09/28] Add read_from_gdb_value method to dwarf_location Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 10/28] Add write_to_gdb_value " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 11/28] Add is_implicit_ptr_at " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 12/28] Add indirect_implicit_ptr to dwarf_location class Zoran Zaric
2021-10-26 20:52 ` Lancelot SIX
2021-11-03 15:11 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 13/28] Add is_optimized_out " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 14/28] Add new computed struct value callback interface Zoran Zaric
2021-10-26 22:50 ` Lancelot SIX
2021-11-04 11:32 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 15/28] Add to_gdb_value method to DWARF entry class Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 16/28] Change DWARF stack to use new dwarf_entry classes Zoran Zaric
2021-10-31 17:58 ` Lancelot SIX
2021-11-04 12:43 ` Zoran Zaric [this message]
2021-10-14 9:32 ` [PATCH v3 17/28] Remove old computed struct value callbacks Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 18/28] Comments cleanup between expr.h and expr.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 19/28] Remove dwarf_expr_context from expr.h interface Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 20/28] Move read_addr_from_reg function to frame.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 21/28] Add frame info check to DW_OP_reg operations Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 22/28] Remove DWARF expression composition check Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 23/28] Add support for any location description in CFI Zoran Zaric
2021-10-31 22:58 ` Lancelot SIX
2021-11-04 15:09 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 24/28] Add DWARF operations for byte and bit offset Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 25/28] Add support for DW_OP_LLVM_undefined operation Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 26/28] Add support for nested composite locations Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 27/28] Add DW_OP_LLVM_extend DWARF operation Zoran Zaric
2021-11-01 21:48 ` Lancelot SIX
2021-11-04 16:26 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 28/28] Add DW_OP_LLVM_select_bit_piece " Zoran Zaric
2021-11-01 22:25 ` Lancelot SIX
2021-11-04 16:39 ` Zoran Zaric
2021-11-05 11:54 ` [PATCH v3 00/28] Allow location description on the DWARF stack Zaric, Zoran (Zare)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c0be81-7bcd-313d-acf5-8610e3a0e7ed@amd.com \
--to=zoran.zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).