From: Zoran Zaric <zoran.zaric@amd.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 28/28] Add DW_OP_LLVM_select_bit_piece DWARF operation
Date: Thu, 4 Nov 2021 16:39:19 +0000 [thread overview]
Message-ID: <e1301310-1ed5-032e-8a0e-c590feee870b@amd.com> (raw)
In-Reply-To: <20211101222500.prqxzsx2hhg5pips@ubuntu.lan>
>> @@ -0,0 +1,138 @@
>> +# Copyright (C) 2017-2021 Free Software Foundation, Inc.
>> +# Copyright (C) 2020-2021 Advanced Micro Devices, Inc. All rights reserved.
>
> Based on a comment in the following thread:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourceware.org%2Fpipermail%2Fgdb-patches%2F2021-September%2F182104.html&data=04%7C01%7Czoran.zaric%40amd.com%7Ca666d2f8c5c546ff3d4808d99d86755b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637714023668693445%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5JvJg6uxGFRzFLCRBaxVV14fKzWvIlOFTs7YeJp0bT8%3D&reserved=0,
> I guess that this second line of copyright should be removed.
>
> I did not spot in the earlier patch, but it looks that the same line
> remains in gdb.dwarf2/dw2-llvm-extend.exp as well.
>
Thank you, I will fix both in the next version.
>> + } {
>> +
>> + # Odd array elements are in first byte of REGNAME 0 register,
>> + # while even elements are in first byte of REGNAME 1 register.
>> + DW_TAG_variable {
>> + {DW_AT_name var_array}
>> + {DW_AT_type :$array_type_label}
>> + {DW_AT_location {
>> + DW_OP_regx [lindex $dwarf_regnum 0]
>> + DW_OP_LLVM_extend 8 8
>> + DW_OP_regx [lindex $dwarf_regnum 1]
>
> Looks like you have spaces instead of tabs to indent this line.
>
> Best,
> Lancelot.
>
Thank you,
Zoran
next prev parent reply other threads:[~2021-11-04 16:39 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:32 [PATCH v3 00/28] Allow location description on the DWARF stack Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 01/28] Add new register access interface to expr.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 02/28] Add new memory " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 03/28] Add new classes that model DWARF stack element Zoran Zaric
2021-10-21 23:43 ` Lancelot SIX
2021-10-22 16:38 ` Zoran Zaric
2021-10-22 21:34 ` Lancelot SIX
2021-10-14 9:32 ` [PATCH v3 04/28] Add to_location method to DWARF entry classes Zoran Zaric
2021-10-22 21:21 ` Lancelot SIX
2021-10-25 21:23 ` Simon Marchi
2021-11-01 16:01 ` Zoran Zaric
2021-11-01 20:36 ` Simon Marchi
2021-11-01 16:00 ` Zoran Zaric
2021-11-01 17:48 ` Lancelot SIX
2021-10-14 9:32 ` [PATCH v3 05/28] Add to_value " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 06/28] Add read method to location description classes Zoran Zaric
2021-10-25 18:33 ` Lancelot SIX
2021-10-25 21:37 ` Simon Marchi
2021-11-02 14:26 ` Zoran Zaric
2021-11-03 19:03 ` Simon Marchi
2021-11-05 11:58 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 07/28] Add write " Zoran Zaric
2021-10-25 20:21 ` Lancelot SIX
2021-11-03 10:27 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 08/28] Add deref " Zoran Zaric
2021-10-25 22:31 ` Lancelot SIX
2021-11-03 10:51 ` Zoran Zaric
2021-11-03 17:37 ` Simon Marchi
2021-11-05 11:55 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 09/28] Add read_from_gdb_value method to dwarf_location Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 10/28] Add write_to_gdb_value " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 11/28] Add is_implicit_ptr_at " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 12/28] Add indirect_implicit_ptr to dwarf_location class Zoran Zaric
2021-10-26 20:52 ` Lancelot SIX
2021-11-03 15:11 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 13/28] Add is_optimized_out " Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 14/28] Add new computed struct value callback interface Zoran Zaric
2021-10-26 22:50 ` Lancelot SIX
2021-11-04 11:32 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 15/28] Add to_gdb_value method to DWARF entry class Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 16/28] Change DWARF stack to use new dwarf_entry classes Zoran Zaric
2021-10-31 17:58 ` Lancelot SIX
2021-11-04 12:43 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 17/28] Remove old computed struct value callbacks Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 18/28] Comments cleanup between expr.h and expr.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 19/28] Remove dwarf_expr_context from expr.h interface Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 20/28] Move read_addr_from_reg function to frame.c Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 21/28] Add frame info check to DW_OP_reg operations Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 22/28] Remove DWARF expression composition check Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 23/28] Add support for any location description in CFI Zoran Zaric
2021-10-31 22:58 ` Lancelot SIX
2021-11-04 15:09 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 24/28] Add DWARF operations for byte and bit offset Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 25/28] Add support for DW_OP_LLVM_undefined operation Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 26/28] Add support for nested composite locations Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 27/28] Add DW_OP_LLVM_extend DWARF operation Zoran Zaric
2021-11-01 21:48 ` Lancelot SIX
2021-11-04 16:26 ` Zoran Zaric
2021-10-14 9:32 ` [PATCH v3 28/28] Add DW_OP_LLVM_select_bit_piece " Zoran Zaric
2021-11-01 22:25 ` Lancelot SIX
2021-11-04 16:39 ` Zoran Zaric [this message]
2021-11-05 11:54 ` [PATCH v3 00/28] Allow location description on the DWARF stack Zaric, Zoran (Zare)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1301310-1ed5-032e-8a0e-c590feee870b@amd.com \
--to=zoran.zaric@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).