From: Luis Machado <luis.machado@arm.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, v2] aarch64: Check for valid inferior thread/regcache before reading pauth registers
Date: Fri, 24 Mar 2023 06:28:09 +0000 [thread overview]
Message-ID: <f3d8f804-550f-c025-ef79-c2660db28f62@arm.com> (raw)
In-Reply-To: <20230323113927.466085b3@f37-zws-nv>
On 3/23/23 18:39, Kevin Buettner wrote:
> On Thu, 23 Mar 2023 18:32:31 +0000
> Luis Machado <luis.machado@arm.com> wrote:
>
>> On 3/23/23 18:27, Luis Machado wrote:
>>> On 3/23/23 18:25, Kevin Buettner wrote:
>>>> On Thu, 23 Mar 2023 10:56:19 +0000
>>>> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> wrote:
>>>>
>>>>> Changes in v2:
>>>>>
>>>>> - Dropped helper functions and used inferior_ptid/current_inferior ()
>>>>> instead.__ Changes are now aarch64-specific.
>>>>
>>>> A bug which your patch fixes had been reported in Fedora bugzilla; see:
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=2177655
>>>>
>>>> I made a scratch build using your v1 patch and one user reported the
>>>> bug fixed.
>>>>
>>>> I've looked over your v2 patch and it looks good to me.
>>>
>>> Thanks for testing. Andrew B. had pinged me about a report on his end.
>>>
>>> Hopefully we can get this sorted out soon, as it is quite annoying.
>>>
>>>>
>>>> Kevin
>>>>
>>>
>>
>> Worth mentioning that I plan to backport this fix to GDB 13.1, which might require a
>> slightly different patch because in GDB 13 this code is linux-specific instead of
>> OS-independent.
>
> In order to apply your v1 patch to (Fedora) GDB 13.1, I first
> cherry-picked commit 6d0020873de. I think it might make sense
> to do the same for the 13.1 branch.
Though that works, it will enable pauth support for bare metal in GDB 13.1. The change could be
backported without that particular feature.
>
> Kevin
>
next prev parent reply other threads:[~2023-03-24 6:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 10:39 [PATCH] " Luis Machado
2023-03-16 15:49 ` Andrew Burgess
2023-03-16 23:15 ` Luis Machado
2023-03-17 17:15 ` Simon Marchi
2023-03-17 17:25 ` Luis Machado
2023-03-17 17:29 ` Simon Marchi
2023-03-17 17:38 ` Luis Machado
2023-03-20 20:06 ` Andrew Burgess
2023-03-22 10:26 ` Luis Machado
2023-03-23 10:56 ` [PATCH, v2] " Luis Machado
2023-03-23 18:25 ` Kevin Buettner
2023-03-23 18:27 ` Luis Machado
2023-03-23 18:32 ` Luis Machado
2023-03-23 18:39 ` Kevin Buettner
2023-03-24 6:28 ` Luis Machado [this message]
2023-03-24 8:19 ` Luis Machado
2023-03-24 13:42 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3d8f804-550f-c025-ef79-c2660db28f62@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).