[Bug breakpoints/21969] watchpoint break not triggered on reverse continue

[Bug breakpoints/21969] watchpoint break not triggered on reverse continue

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21969

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot org
            Version|8.0                         |7.10

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/21969] watchpoint break not triggered on reverse continue

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21969

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hannes Domani <ssbssa@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=288363c1737f93e2f7cb8c06026c11a5ff77fb58

commit 288363c1737f93e2f7cb8c06026c11a5ff77fb58
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Wed Dec 6 13:45:51 2023 +0100

    Fix hardware watchpoints in replay mode

    Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597
    caused a regression that meant hardware watchpoint stops would not
    trigger in reverse execution or replay mode.  This was documented in
    PR breakpoints/21969.
    The problem is that record_check_stopped_by_breakpoint always overwrites
    record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT
    value which would be checked afterwards.

    This commit fixes that by not overwriting the stop-reason in
    record_full_stop_reason if we're not stopped at a breakpoint.

    And the test for hw watchpoints in gdb.reverse/watch-reverse.exp actually
    tested sw watchpoints again, since "set can-use-hw-watchpoints 1"
    doesn't convert enabled watchpoints to use hardware.
    This is fixed by disabling said watchpoint while enabling hw watchpoints.
    The same is not done for gdb.reverse/watch-precsave.exp, since it's not
    possible to use hw watchpoints in restored recordings anyways.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=21969
    Approved-by: Guinevere Larsen <blarsen@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug breakpoints/21969] watchpoint break not triggered on reverse continue

[ssbssa at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=21969

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |15.1
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Hannes Domani <ssbssa at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.